-
Notifications
You must be signed in to change notification settings - Fork 1
feat: auto auth #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto auth #173
Conversation
|
Windows and Mac build successful in Launcher Rust!! You can find a link to the downloadable artifact below.
|
…t on start, headless mode
* adding new commands to edit dmg * correct tauri path * correct tauri path * correct create-dmg command * correct create-dmg command * consolidate and simplify changes * remove background validation * remove commented code * correct background path and app name * added back .app to icon name and remove drop-link * change to brew install --------- Co-authored-by: Nick Khalow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on windows and mac following the instructions, testing evidence can be found here decentraland/unity-explorer#5636
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
PR introduces an auto-authentication on first launch feature. How it does work: now the launcher installer carries an embedded one-time UUID auth token that allows new users to get logged in automatically on their first run, bypassing the manual login step.
The implementation includes:
/Applications/folder, reading url from the where from attr (if exists) via xattr to obtain the token.auth-token-bridge.txtin its working directory. The client (with changes from feat: auto login unity-explorer#5636) will detect this file on startup and consume the token to authenticate the user automatically. This approach bridges the launcher and Unity client, allowing the token to be used for login without manual input.Consumption via .txt token file
Once the token is extracted on either platform, the launcher uses a simple file-based bridge to hand it off
to the Explorer client:
auth-token-bridge.txt. The token is only used once on first launch.Test Instructions
For end-to-end test, follow these steps: