Skip to content

feat: on chain base emotes #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 30, 2025
Merged

feat: on chain base emotes #5557

merged 10 commits into from
Oct 30, 2025
+23 −25

Conversation

@lorux0
Copy link
Collaborator

@lorux0 lorux0 commented Sep 24, 2025 •
edited
Loading

What does this PR change?

Fixes #672

We need to wait until all of the emotes are deployed into prod before merging this changes.

Test Instructions

NOTE: Your avatar and many of the backpack slots might not load because the today environment has a lot of missing content.

  1. Open the backpack
  2. Go to the emote section
  3. Try switching pages until base emotes load
  4. Equip them
  5. Check that sounds play on clap, money and kiss.

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@lorux0 lorux0 mentioned this pull request Sep 24, 2025
Closed
@lorux0 lorux0 changed the title Feat/remove base emotes feat: remove embedded emotes Sep 24, 2025
@lorux0 lorux0 changed the title feat: remove embedded emotes feat: on chain base emotes Sep 24, 2025
@lorux0
Merge branch 'dev' into feat/remove-base-emotes
3755490 
# Conflicts:
#	Explorer/Assets/DCL/Backpack/EmotesSection/BackpackEmoteGridController.cs
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025 •
edited
Loading

badge

Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 5d012e6
Logs https://github.com/decentraland/unity-explorer/actions/runs/18943384161
Download Windows https://github.com/decentraland/unity-explorer/suites/48778692865/artifacts/4418927336
Download Windows S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/remove-base-emotes/pr-15460-5d012e6/Decentraland_windows64.zip
Download Mac https://github.com/decentraland/unity-explorer/suites/48778692865/artifacts/4418726083
Download Mac S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/remove-base-emotes/pr-15460-5d012e6/Decentraland_macos.zip
Built on 2025-10-30T14:50:56Z

@lorux0
Merge branch 'dev' into feat/remove-base-emotes
3b5e6c2
@lorux0
Merge branch 'dev' into feat/remove-base-emotes
387e8c3 
# Conflicts:
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
@lorux0 lorux0 marked this pull request as ready for review October 24, 2025 12:59
@lorux0 lorux0 requested review from a team as code owners October 24, 2025 12:59
@github-actions github-actions bot requested review from DafGreco, dalkia and popuz October 24, 2025 12:59
@lorux0 lorux0 added do not merge force-build Used to trigger a build on draft PR and removed do not merge labels Oct 24, 2025
@anicalbano anicalbano self-requested a review October 24, 2025 18:38
anicalbano
anicalbano approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Tested on MacOS and Windows
✔️ Working as expected in both platforms
✔️ No further issues were found

24.10.2025_15.37.12_REC.mp4
24.10.2025_15.31.21_REC.mp4

@lorux0 lorux0 added do not merge force-build Used to trigger a build on draft PR and removed do not merge force-build Used to trigger a build on draft PR labels Oct 27, 2025
@anicalbano anicalbano self-requested a review October 28, 2025 12:58
anicalbano
anicalbano approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Reviewed on Windows and MacOS in main and working as expected

28.10.2025_08.01.38_REC.mp4

There is another issue related to the wheel, but not related to this PR

@anicalbano anicalbano self-requested a review October 30, 2025 13:49
@lorux0
Merge branch 'dev' into feat/remove-base-emotes
5d012e6 
# Conflicts:
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
@lorux0 lorux0 enabled auto-merge (squash) October 30, 2025 14:05
@lorux0 lorux0 merged commit 86e8c37 into dev Oct 30, 2025
5 of 6 checks passed
@lorux0 lorux0 deleted the feat/remove-base-emotes branch October 30, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidejensen davidejensen davidejensen approved these changes

@anicalbano anicalbano anicalbano approved these changes

@DafGreco DafGreco Awaiting requested review from DafGreco

@dalkia dalkia Awaiting requested review from dalkia

@popuz popuz Awaiting requested review from popuz

Assignees

@lorux0 lorux0

Labels

force-build Used to trigger a build on draft PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove hardcoded base emotes and move them to collection

4 participants

@lorux0 @davidejensen @anicalbano