feat: refactor nametags to UI Toolkit and add official badge #5657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
mihakrajnc
force-pushed
the
feat/ui_toolkit_nametags
branch
from
da9ff9e to
61b957b
Compare
fcolarich
reviewed
Oct 2, 2025
Explorer/Assets/DCL/Infrastructure/Global/Dynamic/MainSceneLoader.cs
Outdated
Show resolved
Hide resolved
fcolarich
reviewed
Oct 2, 2025
fcolarich
reviewed
Oct 2, 2025
9 tasks
RominaMarchetti
requested changes
Oct 9, 2025
There was a problem hiding this comment.
There are some things that are off regarding.
Check the following:
- All the name tags have the peak permanently visible, when they shouldn’t. That asset must be visible for chat bubbles only.
- The name tag container looks black, when it is supposed to be dark grey with a lighter outline. The bubble peak should match the outline colour.
- Mention bubble: check the video carefully. The scene FXs are messing up with the UI.
https://github.com/user-attachments/assets/5bd03c5f-350f-4c34-8782-1d395e2bc099
dalkia
requested changes
Oct 9, 2025
|
@dalkia @RominaMarchetti Fixed all reported issues. |
dalkia
approved these changes
Oct 10, 2025
Ludmilafantaniella
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Tested on both Windows and Mac — everything works as expected ✅
Nametags function correctly (chat messages, community messages, voice chat icons, etc.) and the DCL Official badge appears properly when enabled via feature flag.
🧵 Attaching here the related discussion thread where I reported findings and feedback during testing for reference: Thread link
nametag.mp4
✅ Regressions performed in order to verify that the normal flow is working as expected:
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- ✔️ Teleport with map/coordinates/Jump In
- ✔️ Chat and multiplayer
- ✔️ Profile card
- ✔️ Camera
- ✔️ Skybox
- ✔️ Voice Chat
RominaMarchetti
approved these changes
Oct 10, 2025
This was referenced Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This refactors the nametags to use world space ui toolkit instead of uGUI, and adds the "DCL Official" badge next to official accounts (only in nametags). Some animations / transitions might be slightly different but should match fairly well to the old version
What does this PR change?
Test Instructions
Ensure that all the existing nametag functionality still works, and that official accounts (wallet id's need to be added to the feature flag) show the DCL Official nametag.
Prerequisites
Test Steps
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.