Skip to content

Conversation

@lorenzo-ranciaffi
Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi commented Oct 2, 2025

Pull Request Description

Fixes #5648
Fixes #5709

What does this PR change?

This PR reintroduces the analytics for chat:

  • select a new conversation
  • close a conversation
    by plugging into the new architecture's proper commands.

In order to avoid duplicate analytics entries, some small fixes have been applied, such as the removal of dead event subscriptions to pooled objects.

Test Instructions

Test Steps

  1. Just test that the chat works as normal
  2. Include log out/log in to verify everything works as normal

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

@lorenzo-ranciaffi lorenzo-ranciaffi moved this from Todo to With QA / Awaiting Review in Explorer Alpha Oct 3, 2025
@lorenzo-ranciaffi lorenzo-ranciaffi marked this pull request as ready for review October 3, 2025 14:03
@lorenzo-ranciaffi lorenzo-ranciaffi requested review from a team as code owners October 3, 2025 14:03
@anicalbano
Copy link
Contributor

Also fixes #5709

Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [✔️ ] On boarding with new account
  • [✔️ ] Log In/Log Out
  • [✔️ ] Backpack and wearables in world
  • [✔️ ] Emotes in world and in backpack
  • [✔️ ] Teleport with map/coordinates/Jump In
  • [✔️ ] Chat and multiplayer
  • [✔️ ] Profile card
  • [✔️ ] Camera
  • [✔️ ] Skybox
  • [ ✔️] Settings

Evidence :

20251013-0810-28.8918676.mp4
20251013-0812-45.4988348.mp4
image (12)

@github-project-automation github-project-automation bot moved this from With QA / Awaiting Review to In Progress in Explorer Alpha Oct 13, 2025
@lorenzo-ranciaffi lorenzo-ranciaffi enabled auto-merge (squash) October 13, 2025 08:25
@lorenzo-ranciaffi lorenzo-ranciaffi merged commit 985b482 into dev Oct 13, 2025
7 of 10 checks passed
@lorenzo-ranciaffi lorenzo-ranciaffi deleted the fix/5648-chat-analytics branch October 13, 2025 08:26
@github-project-automation github-project-automation bot moved this from In Progress to Done in Explorer Alpha Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[QA] Help panel | DCL system title name appears twice in the bubble Re add Missing Chat Analytics

5 participants