-
Notifications
You must be signed in to change notification settings - Fork 14
fix: re-implement chat analytics #5659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
|
Also fixes #5709 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- [✔️ ] On boarding with new account
- [✔️ ] Log In/Log Out
- [✔️ ] Backpack and wearables in world
- [✔️ ] Emotes in world and in backpack
- [✔️ ] Teleport with map/coordinates/Jump In
- [✔️ ] Chat and multiplayer
- [✔️ ] Profile card
- [✔️ ] Camera
- [✔️ ] Skybox
- [ ✔️] Settings
Evidence :
20251013-0810-28.8918676.mp4
20251013-0812-45.4988348.mp4
Pull Request Description
Fixes #5648
Fixes #5709
What does this PR change?
This PR reintroduces the analytics for chat:
by plugging into the new architecture's proper commands.
In order to avoid duplicate analytics entries, some small fixes have been applied, such as the removal of dead event subscriptions to pooled objects.
Test Instructions
Test Steps
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.