Skip to content

Conversation

@lorenzo-ranciaffi
Copy link
Contributor

Pull Request Description

Fixes #5718

What does this PR change?

This PR restores the logic for losing chat focus when while typing, the user presses the escape button as it was in this PR.
Probably this code portion was lost because of merge conflicts during the multiple refactors that have been made with chat and voice chat.

Test Instructions

Test Steps

  1. Verify that the steps described in the linked issue are now fixed

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

@lorenzo-ranciaffi lorenzo-ranciaffi marked this pull request as ready for review October 8, 2025 10:45
@lorenzo-ranciaffi lorenzo-ranciaffi requested review from a team as code owners October 8, 2025 10:45
@lorenzo-ranciaffi lorenzo-ranciaffi moved this from Todo to With QA / Awaiting Review in Explorer Alpha Oct 8, 2025
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ QA Approved
Tested on Windows and Mac.
The chat input now correctly loses focus when pressing ESC, restoring the expected behavior.
All related functionality works as intended — shortcuts and chat interactions behave normally.

5721-fixevi.mp4

@github-project-automation github-project-automation bot moved this from With QA / Awaiting Review to In Progress in Explorer Alpha Oct 8, 2025
@lorenzo-ranciaffi lorenzo-ranciaffi merged commit 94175ee into dev Oct 9, 2025
13 of 16 checks passed
@lorenzo-ranciaffi lorenzo-ranciaffi deleted the fix/5718-lose-chat-focus-on-escape branch October 9, 2025 08:21
@github-project-automation github-project-automation bot moved this from In Progress to Done in Explorer Alpha Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[QA] Chat | ESC does not deselect input

4 participants