feat: improve license checks #232
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 9, 2025 15:49
- Added `getLicenseType` function to determine expected license type based on file path. - Enhanced `checkFileCopyright` to validate files against CE and EE license requirements. - Introduced comprehensive test cases for license detection and validation logic.
- Changed copyright year from 2021 to 2025 in various test cases and regex patterns for license validation. - Enhanced regex for EE license to match the updated copyright format. - Added new tests to verify the correct matching of the updated license format.
- Modified the file retrieval method in `CheckFiles` to include hidden files by changing the second parameter of `fsutils.GetFiles` from `false` to `true`. - This change ensures that all relevant files, including hidden ones, are considered during license checks.
added 3 commits
July 9, 2025 16:18
- Modified the regex pattern for EE license to improve matching accuracy. - Updated test cases to reflect changes in license comment format from single-line to multi-line. - Adjusted file permissions in test setup to enhance security by restricting access.
- Changed file permissions for the wrong license test file from 0644 to 0600 to enhance security by restricting access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the license validation logic in the
pkg/linters/module/rulespackage. The changes enhance the ability to differentiate between Community Edition (CE) and Enterprise Edition (EE) licenses, streamline file filtering, and improve modularity by removing unused imports and redundant code.License Validation Enhancements:
LicenseTypeenumeration to distinguish between CE and EE licenses, and implemented thegetLicenseTypefunction to determine the expected license type based on file paths. Files in directories starting with "ee" are expected to have an EE license, while others default to a CE license. (pkg/linters/module/rules/license_library.go, pkg/linters/module/rules/license_library.goL51-R80)EELicenseRe, to validate EE license headers. Updated thecheckFileCopyrightfunction to validate the license type based on the file path and provide detailed error messages when mismatches occur. (pkg/linters/module/rules/license_library.go, [1] [2]Code Simplification:
license.goto clean up the codebase. (pkg/linters/module/rules/license.go, pkg/linters/module/rules/license.goL22-L25)filterFilesfunction, relying instead on existing regular expressions for file matching. (pkg/linters/module/rules/license.go, pkg/linters/module/rules/license.goL77-L84)Additional Improvements:
CELicenseReregular expression to account for optional "C" in "Flant C?JSC" to improve flexibility in CE license validation. (pkg/linters/module/rules/license_library.go, pkg/linters/module/rules/license_library.goR23-R28)