Skip to content

feat: enhance Grafana dashboard validation rules #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: enhance Grafana dashboard validation rules #251

wants to merge 2 commits into from

Conversation

juev
Copy link
Contributor

@juev juev commented Aug 18, 2025 •
edited
Loading

Added new grafana-dashboards linters:

  • Deprecated Panel Types
  • Deprecated Intervals
  • Legacy Alert Rules
  • Datasource Validation
  • Template Variables

Example:

🐒 [grafana (#templates)]
     Message:      Panel 'Incoming Request Duration By Source' uses deprecated type 'graph', consider using
                   'timeseries'
     Module:       istio
     FilePath:     /deckhouse/modules/110-istio/monitoring/grafana-dashboards/istio/service.json

🐒 [grafana (#templates)]
     Message:      Panel 'Incoming Success Rate (non-5xx responses) By Source' uses deprecated type 'graph', consider
                   using 'timeseries'
     Module:       istio
     FilePath:     /deckhouse/modules/110-istio/monitoring/grafana-dashboards/istio/service.json

🐒 [grafana (#templates)]
     Message:      Panel 'Incoming Success Rate (non-5xx responses) By Destination Workload' uses deprecated type
                   'graph', consider using 'timeseries'
     Module:       istio
     FilePath:     /deckhouse/modules/110-istio/monitoring/grafana-dashboards/istio/service.json

🐒 [grafana (#templates)]
     Message:      Panel 'Incoming Request Duration By Service Workload' uses deprecated type 'graph', consider using
                   'timeseries'
     Module:       istio
     FilePath:     /deckhouse/modules/110-istio/monitoring/grafana-dashboards/istio/service.json

feat: enhance Grafana dashboard validation rules
b3f5c18 
- Updated gjson version in go.mod and go.sum.
- Added comprehensive validation rules for Grafana dashboards, including checks for deprecated panel types, intervals, legacy alert rules, and datasource validation.
- Introduced tests for the new validation rules to ensure correctness and reliability.
@juev juev requested a review from ldmonster August 18, 2025 12:58
@juev juev self-assigned this Aug 18, 2025
chore: update gjson dependency in go.sum
533f990 
- Removed outdated gjson version 1.14.4.
- Updated to the latest gjson version 1.18.0 for improved functionality and security.
@juev juev marked this pull request as ready for review August 18, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldmonster ldmonster Awaiting requested review from ldmonster

Assignees

@juev juev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juev