-
Notifications
You must be signed in to change notification settings - Fork 3
[dmt] Add feature flag #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Sinelnikov Michail <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for rule-specific impact configuration at the module level, allowing you to override the severity level (error/warn/ignored) for specific linter rules.
What's added
1. Rule-specific Impact in Linter Settings
RulesSettings map[string]RuleSettings
field to all linter settings structuresGetRuleImpact(ruleName string) *pkg.Level
andSetRuleImpact(ruleName string, impact *pkg.Level)
methods for all linter settingsmodule
,container
,hooks
,images
,no-cyrillic
,openapi
,rbac
,templates
2. Rule Impact Function in Error System
RuleImpactFunc func(linterID, ruleID string) *pkg.Level
inpkg/errors/errors.go
ruleImpactFunc RuleImpactFunc
field to theLintRuleErrorsList
structureadd
method to apply rule-specific impact beforemaxLevel
3. Improved error display
internal/manager/manager.go
4. DTO/Runtime Architecture Separation
Added Runtime structures in pkg/config/runtime.go:
RuntimeRootConfig
,RuntimeLintersSettings
for executionAdded remapper functions in pkg/config/remapper.go:
ToRuntime() methods for converting DTO -> Runtime with global settings merging
Added adapter functions in pkg/config/adapter.go:
ToLintersSettings() for backward compatibility with existing linters
5. Configuration Loading Refactoring
Local module configuration (
dmt-config.yaml
in the module folder):Tests