-
Notifications
You must be signed in to change notification settings - Fork 2
fix(vd,vi): prevent empty storage class in allowedStorageClassSelector #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: cancelled. |
Signed-off-by: Daniil Loktev <[email protected]>
Workflow has started. The target step completed with status: cancelled. |
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: cancelled. |
Workflow has started. The target step completed with status: cancelled. |
Workflow has started. The target step completed with status: failure. |
Workflow has started. The target step completed with status: success. |
Signed-off-by: Daniil Loktev <[email protected]>
Workflow has started. The target step completed with status: success. |
Description
Added validation to prevent empty strings in allowedStorageClassSelector.matchNames configuration for VirtualDisks and VirtualImages. The fix includes:
Why do we need it, and what problem does it solve?
When allowedStorageClassSelector.matchNames: [""] was configured in ModuleConfig the restriction didn't work, allowing creation of disks with any storage class
What is the expected result?
Checklist
Changelog entries