Skip to content

fix(e2e): fix false positive resource apply error #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(e2e): fix false positive resource apply error #1428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/e2e/affinity_toleration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ var _ = Describe("VirtualMachineAffinityAndToleration", ginkgoutil.CommonE2ETest

Context("When the virtualization resources are applied:", func() {
It("result should be succeeded", func() {
vmClassFilePath := fmt.Sprintf("%s/vmc.yaml", conf.TestData.AffinityToleration)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you apply this file, the name of the virtual machine class will not be "kustomized".

vmcRes := kubectl.Apply(kc.ApplyOptions{
Filename: []string{vmClassFilePath},
FilenameOption: kc.Filename,
})
Expect(vmcRes.Error()).NotTo(HaveOccurred(), "failed to apply virtual class resource")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Expect(vmcRes.Error()).NotTo(HaveOccurred(), "failed to apply virtual class resource")
Expect(vmcRes.Error()).NotTo(HaveOccurred(), "failed to apply virtual machine class resource")


res := kubectl.Apply(kc.ApplyOptions{
Filename: []string{conf.TestData.AffinityToleration},
FilenameOption: kc.Kustomize,
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/complex_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ var _ = Describe("ComplexTest", Serial, ginkgoutil.CommonE2ETestDecorators(), fu
}
}

vmClassFilePath := fmt.Sprintf("%s/vmc.yaml", conf.TestData.ComplexTest)
vmcRes := kubectl.Apply(kc.ApplyOptions{
Filename: []string{vmClassFilePath},
FilenameOption: kc.Filename,
})
Expect(vmcRes.Error()).NotTo(HaveOccurred(), "failed to apply virtual class resource")

res := kubectl.Apply(kc.ApplyOptions{
Filename: []string{conf.TestData.ComplexTest},
FilenameOption: kc.Kustomize,
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/sizing_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ var _ = Describe("SizingPolicy", ginkgoutil.CommonE2ETestDecorators(), func() {

Context("When resources are applied", func() {
It("result should be succeeded", func() {
vmClassFilePath := fmt.Sprintf("%s/vmc.yaml", conf.TestData.SizingPolicy)
vmcRes := kubectl.Apply(kc.ApplyOptions{
Filename: []string{vmClassFilePath},
FilenameOption: kc.Filename,
})
Expect(vmcRes.Error()).NotTo(HaveOccurred(), "failed to apply virtual class resource")

res := kubectl.Apply(kc.ApplyOptions{
Filename: []string{conf.TestData.SizingPolicy},
FilenameOption: kc.Kustomize,
Expand Down
Loading