Skip to content

chore(module): rename containers to support integrity checks #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: mount-points
Choose a base branch
from
Open

chore(module): rename containers to support integrity checks #1432

wants to merge 3 commits into from
+30 −17

Conversation

diafour
Copy link
Member

@diafour diafour commented Sep 4, 2025 •
edited
Loading

Description

  1. Rename containers of kubevirt Pods, cdi Pods and dvcr Pods created in non-system namespaces (namespaces without the d8- prefix).

  2. Mount container-disk binary into /var/run in container with user uploaded image (support attaching cvi, vi to vm).

Related PRs:
deckhouse/3p-kubevirt#19
deckhouse/3p-containerized-data-importer#17
#1343

Why do we need it, and what problem does it solve?

Support containerd integrity checking for system images.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: module
type: chore
summary: Support containerd integrity checks for containers with system images running in non-system namespaces.

@diafour diafour added this to the v1.0.0 milestone Sep 4, 2025
@diafour diafour added e2e/user/universal-itengineer e2e/run Run e2e test on cluster of PR author labels Sep 5, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 5, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 5, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 5, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@diafour diafour added e2e/user/hardcoretime e2e/run Run e2e test on cluster of PR author and removed e2e/user/universal-itengineer labels Sep 5, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 5, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 5, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 5, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 5, 2025
@diafour diafour force-pushed the chore/module/support-containerd-integrity-checks branch from b308028 to 5516243 Compare September 8, 2025 09:19
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 9, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 9, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 9, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 9, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 9, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 10, 2025
@diafour diafour force-pushed the chore/module/support-containerd-integrity-checks branch from 5516243 to dbe7a5d Compare September 10, 2025 14:40
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 10, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 10, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 10, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 10, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 10, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 10, 2025
@diafour diafour mentioned this pull request Sep 10, 2025
Merged
4 tasks
@diafour diafour mentioned this pull request Sep 10, 2025
Open
5 tasks
@diafour
chore(module): rename containers to support integrity checks
9d48e99 
1. Rename containers of kubevirt Pods, cdi Pods and dvcr Pods created in non-system namespaces (namespaces without d8- prefix).

2. Mount container-disk binary into /var/run in container with user uploaded image (support attaching cvi, vi to vm).

Related PRs:
deckhouse/3p-kubevirt#19
deckhouse/3p-containerized-data-importer#17

Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour diafour force-pushed the chore/module/support-containerd-integrity-checks branch from 4f8e36c to 9d48e99 Compare September 10, 2025 21:23
diafour
diafour commented Sep 10, 2025
View reviewed changes
build/components/versions.yml
Comment on lines -6 to +9
3p-kubevirt: v1.3.1-v12n.11
3p-containerized-data-importer: v1.60.3-v12n.9
#3p-kubevirt: v1.3.1-v12n.12
3p-kubevirt: dvp/chore/support-containerd-integrity-checks
#3p-containerized-data-importer: v1.60.3-v12n.10
3p-containerized-data-importer: dvp/chore/support-containerd-integrity-check-for-containers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: change after merging PRs and tagging 3p repositories.

@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Sep 11, 2025
Merged
4 tasks
@diafour
++ rebuild cdi,kubevirt
e449ad1 
Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour
++ rebuild kubevirt
715e169 
Signed-off-by: Ivan Mikheykin <[email protected]>
@nevermarine nevermarine modified the milestones: v1.0.0, v1.1.0 Sep 11, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Sep 12, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Sep 12, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z9r5 z9r5 z9r5 approved these changes

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@universal-itengineer universal-itengineer Awaiting requested review from universal-itengineer universal-itengineer is a code owner

@nevermarine nevermarine Awaiting requested review from nevermarine nevermarine is a code owner

@hardcoretime hardcoretime Awaiting requested review from hardcoretime

@danilrwx danilrwx Awaiting requested review from danilrwx

@goganat goganat Awaiting requested review from goganat

Assignees

@diafour diafour

Labels
e2e/user/hardcoretime
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@diafour @deckhouse-BOaTswain @z9r5 @nevermarine