Skip to content

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Sep 4, 2025

Cookbook for this PR deepset-ai/haystack-experimental#359

Some feedback on this from @julian-risch deepset-ai/haystack-experimental#359 (comment)

Would be great to have also a RAG Pipeline example that uses a DocumentStore and a Retriever. It doesn't stop us from merging this PR but I believe it would help users to try out the new feature and we should add it in another PR.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sjrl sjrl marked this pull request as ready for review September 4, 2025 11:44
@sjrl sjrl requested a review from a team as a code owner September 4, 2025 11:44
@sjrl sjrl requested a review from julian-risch September 4, 2025 11:44
@sjrl
Copy link
Contributor Author

sjrl commented Sep 4, 2025

@julian-risch this is ready for review! It includes an example now where we create a RAG Query pipeline

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Except for my comment above, I don't have any comments on how to improve. The RAG example is really great to have! The output cell at the very end with an example of no answer due to missing relevant documents too.
Disclaimer: I did not run the code.

@@ -0,0 +1,435 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a risk here although the answer is basically the evidence provided in the prompt?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a risk bound and the risk is assessed based on this number and a threshold. I can't say I fully understand how it works this was mostly copied from the original repo.

@@ -0,0 +1,435 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAG-based Example


Reply via ReviewNB

Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my comments! Can you also add the notebook to the index.toml for it to be rendered on the website. Here's an example for notebooks with experimental components.

@julian-risch
Copy link
Member

Experimental release is done. I'll merge this notebook so that we can link to it in release notes.

@julian-risch julian-risch merged commit d3183ba into main Sep 4, 2025
1 check passed
@julian-risch julian-risch deleted the hallucation-score branch September 4, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants