Update for Swift 4.2 support #418
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unneeded entry of `Info.plist` from the `Copy Bundle Resources` build phase. - Apply Xcode suggested project settings updates. - Convert `SlideMenuControllerSwift` scheme to Swift 4.2. - Convert `SlideMenuControllerSwift-iOS` scheme to Swift 4.2. - Update `podspec` to increase version number to `4.2.0`. - Add `swift_version` to `podspec` (`4.2`). - Update `CHANGELOG.md` to indicate Swift 4.2 change.
rtemple6
approved these changes
Feb 3, 2019
|
Are these changes still pending merging to the master branch? |
|
Hi, how can I add this commit to mi podfile? I'm trying with this:
but this doesn't work, the result with pod update is:
Thanks in advance. |
|
👋 @juanm4, Until this is merged in, you would need to refer to my fork. |
|
Shows the following warning
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info.plistfrom theCopy Bundle Resourcesbuild phase.SlideMenuControllerSwiftscheme to Swift 4.2.SlideMenuControllerSwift-iOSscheme to Swift 4.2.podspecto increase version number to4.2.0.swift_versiontopodspec(4.2).CHANGELOG.mdto indicate Swift 4.2 change.Closes #399, #398, #383 & #378