misc: Create expression benchmark for default engine #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
This was referenced Aug 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
+ Coverage 83.81% 83.98% +0.16%
==========================================
Files 111 111
Lines 26223 26175 -48
Branches 26223 26175 -48
==========================================
+ Hits 21980 21983 +3
+ Misses 3147 3098 -49
+ Partials 1096 1094 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scovich
approved these changes
Aug 27, 2025
kernel/benches/expression_bench.rs
Outdated
| use delta_kernel::arrow::datatypes::{DataType, Field, Fields}; | ||
| use delta_kernel::engine::arrow_expression::evaluate_expression::to_json; | ||
|
|
||
| use criterion::{black_box, criterion_group, criterion_main, BenchmarkId, Criterion, Throughput}; |
There was a problem hiding this comment.
According to the docs for black_box:
👎Deprecated: use std::hint::black_box() instead
There was a problem hiding this comment.
Oh true. I didn't notice because we are using an older version of criterion (from 2023) in which this wasn't deprecated yet. Should we upgrade?
lbhm
force-pushed
the
expression-benchmark
branch
from
0dc37b4 to
7cc435f
Compare
lbhm
force-pushed
the
expression-benchmark
branch
from
7cc435f to
1cf0b1c
Compare
zachschuermann
removed
the
breaking-change
murali-db
pushed a commit
to murali-db/delta-kernel-rs
that referenced
this pull request
Sep 17, 2025
## What changes are proposed in this pull request? delta-io#1192 added a makeshift benchmark test to measure the performance of the new `ToJson` expression. This PR migrates this test to a dedicated `expression_bench` for the default engine. This PR only adds `ToJson` to `expression_bench`, but this can be extended as necessary in future PRs. ## How was this change tested? N/A - this PR adds a performance benchmark. --------- Co-authored-by: Zach Schuermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
#1192 added a makeshift benchmark test to measure the performance of the new
ToJsonexpression. This PR migrates this test to a dedicatedexpression_benchfor the default engine.This PR only adds
ToJsontoexpression_bench, but this can be extended as necessary in future PRs.How was this change tested?
N/A - this PR adds a performance benchmark.