[For Review Only] Add initial APIs to working with metadata tree #1271
+183
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2025
github-actions
bot
added
the
breaking-change
Fokko
reviewed
Sep 9, 2025
| /// The metadata passed in here is expected to be taken from the output of a scan of the | ||
| /// table. | ||
| /// The expected schema for `remove_metadata` is given by [`crate::scan::scan_row_schema`]. | ||
| pub fn remove_files(&mut self, remove_metadata: Box<dyn EngineData>) { |
There was a problem hiding this comment.
I noticed that this is also addressed here: https://github.com/delta-io/delta-kernel-rs/pull/1020/files#diff-241320506790ddcf1809819f7905f4463afa829dc71b1c76710fb968c450623dR288
Maybe we can get that PR in first
There was a problem hiding this comment.
This is from the top of the stack which references that PR. That PR never got merged so hopefully we can close it out on #1242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.