Skip to content

chore: deprecate execute since it's too simplistic #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: deprecate execute since it's too simplistic #1273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23acccd
chore: deprecate execute since it's too simplistic
rtyler Sep 9, 2025
656588d
Merge branch 'main' into chore/deprecate-execute
rtyler Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kernel/src/table_changes/scan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,10 @@ impl TableChangesScan {
/// to read and process all the data for the query. Each [`ScanResult`] in the resultant iterator
/// encapsulates the raw data and an optional boolean vector built from the deletion vector if it
/// was present. See the documentation for [`ScanResult`] for more details.
#[deprecated(
since = "0.15.3",
note = "execute is a good example, but is too naive and will be removed in the near future"
)]
pub fn execute(
&self,
engine: Arc<dyn Engine>,
Expand Down
Loading