Skip to content

feat: add deletion_vector_descriptor method #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

feat: add deletion_vector_descriptor method #3721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c25846b
add deletion_vector_descriptor method
zeevm Aug 31, 2025
7dccd3c
chore: add some rustdoc for a new/temporary public method
rtyler Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/core/src/kernel/snapshot/iterators.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,14 @@ impl LogicalFileView {
.map(|s| round_ms_datetimes(s, &ceil_datetime))
}

Copy link
Preview

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new public method deletion_vector_descriptor lacks documentation. Consider adding a doc comment explaining what the method returns and when it would be None.

Copilot uses AI. Check for mistakes.

/// Return the underlying [DeletionVectorDescriptor] if it exists.
///
/// **NOTE**: THis API may be removed in the future without deprecation warnings as the
/// utilization of deletion vectors inside of delta-rs becomes more sophisticated.
pub fn deletion_vector_descriptor(&self) -> Option<DeletionVectorDescriptor> {
self.deletion_vector().map(|dv| dv.descriptor())
}

/// Returns a view into the deletion vector for this file, if present.
fn deletion_vector(&self) -> Option<DeletionVectorView<'_>> {
let dv_col = self
Expand Down
Loading