fix(check): support "compilerOptions.rootDirs" in tsconfig #30495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
commented
Aug 22, 2025
Comment on lines
+1210
to
+1216
| // TODO(nayeemrmn): This represents a circular dependency between | ||
| // `LspCompilerOptionsResolver` and `LspResolver` because the former uses | ||
| // the node resolver to resolve `extends` in tsconfig. Break out the node | ||
| // resolver from `LspResolver`. | ||
| self | ||
| .resolver | ||
| .set_compiler_options_resolver(&self.compiler_options_resolver.inner); |
There was a problem hiding this comment.
This is cutting a corner for #30048 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of:
./$typeswas changed to./$types.d.tsor sloppy imports were enabled in a Deno config.The last part for OOTB support is enabling sloppy imports for
compilerOptions.moduleResolution != "nodenext"("bundler"is the only other we plan to support). See #30048.