fix: Improve IDE compatibility and fix PsiElement offset access #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace direct startOffset/endOffset with textRange.startOffset/endOffset - Apply consistent approach for both element and element.parent - Ensure proper line number calculation for unit test generation
- Replace direct startOffset/endOffset with textRange.startOffset/endOffset - Fix range calculation in IDEUtils.kt - Update all CV providers to use proper PsiElement text range access
- Replace PluginManagerCore with PluginManager for version retrieval - Fix element range calculation using textRange property - Make editor retrieval null-safe in TriggerCompletion action
- Replace BrowserUtil.browse(URL(url)) with BrowserUtil.browse(url) - Use getService(Class) instead of service<T>() extension function - Refactor ToolWindowStateListener to use standard conditional logic
- Update version from 0.3.3 to 0.3.9 - Change IntelliJ target version from 2023.2.5 to 2022.3.3 - Extend plugin compatibility to build 243.*
kagami-l
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
textRangeproperty for PsiElement offset access throughout the codebaseThis PR addresses several issues with PsiElement offset access and improves overall IDE compatibility.