[OGC] Add support for Custom Aspect Ratios #91

Fancy2209 · 2025-02-04T13:42:46Z

Description

Adds a video mode for widescreen

Existing Issue(s)

Fixes #73

Fancy2209 · 2025-02-04T17:15:43Z

The cursor displays properly, but games seem to still have issues

Fancy2209 · 2025-02-05T10:23:56Z

I believe this is now ready for review
Only tested VVVVVV as most SDL2 Apps use OpenGX and that also needs changes (guOrtho width has to be different from viewport width)
Can defineteley use some cleanup but I want to make sure I am not doing something wrong

Stuff was setting the viewport and scissor to 854 Renderer now only adjusts projection if it's trying to set the viewport to 640*480 (this feels like not the intended way but I haven't found a better one)

Fancy2209 · 2025-02-05T18:49:56Z

Correction: NOW it's ready for review

I feel like the logic to adjust the orthoWidth on the SDL Renderer is wrong but multiple render targets are a pain since only what's rendered to the screen needs adjusting

src/render/ogc/SDL_render_ogc.c

src/video/ogc/SDL_ogcgxcommon.c

src/video/ogc/SDL_ogcvideo.c

src/video/ogc/SDL_ogcmouse.c

Co-authored-by: Alberto Mardegan <[email protected]>

…descreen

…rt_w

Fix 4:3 Make mouse actually unstreched on 16:9 Fix SDL_DisplayMode 16:9 width (for real this time)

Fancy2209 · 2025-02-06T00:20:21Z

Btw there's something wrong with the code for centering the window, on widescreen VVVVVVV is setting the window x pos to 207, seems related to SDL_WINDOWPOS_CENTERED_DISPLAY (the x was smaller when I sent the picture above but it changed and I haven't found out why )

mardy · 2025-02-07T19:48:40Z

SDL_WII_RESPECT_ASPECT_RATIO_CONFIG was just to allow apps to go into widescreen by default on wii but I can just make it what happens if SDL_OGC_ASPECT_RATIO isn't set

Makes sense!

Fancy2209 · 2025-02-07T19:58:14Z

By the way just curious, why did you use the std lib directly for OGC_JoystickInit? I thougth that SDL was meant to use the SDL stdlib (as in getenv and strcmp instead of SDL_getenv and SDL_strcmp like the rest of the lib)

Because who doesn't want to make a Wii App that outputs at 21:9?

Fancy2209 · 2025-02-07T22:19:54Z

:)
(Pictured is 21:9, wanted to make sure out of the bat something other than 16:9 worked)

Example usage

SDL_setenv("SDL_OGC_ASPECT_RATIO", "21:9", 1); // Normal setenv works, but no reason to include an extra header if you include SDL in your code directly already

mind you the format is w:h and w > h needs to be true or it will not work since the math doesn't work for when the height is what has to change
Also you can have 2 floats like 21.5:10.1 but I am praying no app does that since no screen does that so it'd just never look right

Fancy2209 · 2025-02-08T01:47:21Z

By the way, something that is really bothering me is that when I set the window to widescreen the mouse starts having pixels jitter, like depending where it is some pixels get cut off in one of the sides

mardy · 2025-02-08T07:45:22Z

By the way just curious, why did you use the std lib directly for OGC_JoystickInit? I thougth that SDL was meant to use the SDL stdlib (as in getenv and strcmp instead of SDL_getenv and SDL_strcmp like the rest of the lib)

SDL is trying to be as portable as possible, so it redefines these functions to allow platforms to reimplement them, if needed. But for us it just introduces a slow-down, since while the stdlib functions can be optimized away from the compiler, the SDL equivalent can not (that's my guess, at least, since it does not know them). I would suggest avoiding them, unless you are writing code in the SDL common modules and you plan to submit it upstream.

src/video/ogc/SDL_ogcgxcommon.c

mardy · 2025-02-08T07:58:40Z

src/video/ogc/SDL_ogcmouse.c

+    if (aspect_w > 4.0f && aspect_h > 3.0f)
+        OGC_load_texture(curdata->texels, curdata->w, curdata->h, GX_TF_RGBA8,
+                         SDL_ScaleModeLinear);
+    else
+        OGC_load_texture(curdata->texels, curdata->w, curdata->h, GX_TF_RGBA8,
+                         SDL_ScaleModeNearest);


I don't understand what this does, and I'm not sure that the if is correct (what if the ratio is 3:2? -- by the way, for this type of checks it appears that using a single float for the aspect ratio instead of two ints would be better).

Note that the scaling is done either by the TV or by the VI interface, so I don't think we should be changing how the texture is being filtered.

The cursor looks very jittery on other aspect ratios, so I changed it to Linear since it wouldn't be as noticeable, but it's still noticeable and I have no idea why it's cutting pixels from the image depending on where it is

mardy · 2025-02-08T08:06:29Z

src/video/ogc/SDL_ogcmouse.c


    guMtxIdentity(mv);
-    guMtxScaleApply(mv, mv, screen_w / 640.0f, screen_h / 480.0f, 1.0f);
+    guMtxScaleApply(mv, mv, screen_w / (480.0f * aspect_w / aspect_h), screen_h / 480.0f, 1.0f);


You cannot do this on the modelview matrix, because then you are actually changing the cursor width, and then if the cursor then gets rotated it will appear wrong. I think that all this code should stay unchanged, and we should only operate on how the OGX_set_viewport function gets called.

It sounds a bit silly, since it was me who introduces this scaling, but looking at it now, it appears wrong: we already have the viewport to do the scaling; can you try to just remove this line?

And in the call to OGC_set_viewport() below, we should probably pass the EFB dimensions, not the screen dimensions adjusted for the aspect ratio (at least if you follow my suggestion about retrieving the aspect ratio from OGC_set_viewport).

Why would I retrieve the aspect ratio from the viewport function tough? I stopped doing a different width for the matrix because it's more correct, an app will look right if it's widescreen
If an app doesn't try to use widescreen, doing work arounds so maybe it'll look right felt wrong

i made the resize be sceen height dependant

mardy · 2025-02-08T08:10:52Z

src/video/ogc/SDL_ogcvideo.c

@@ -157,6 +167,20 @@ static void setup_video_mode(_THIS, GXRModeObj *vmode)
 {
    SDL_VideoData *videodata = (SDL_VideoData *)_this->driverdata;

+    // TODO: Should I make this only happen if the aspect ratio isn't 4:3?


To simplify things I suggest forgetting about the VI changes for now (have them in a separate PR later), because handing of the CONF_GetAspectRatio() is a bit orthogonal to setting the best video mode. It will make testing and reviewing easier, if we tackle one issue at a time.

mardy · 2025-02-08T08:31:39Z

src/video/ogc/SDL_ogcgxcommon.c

+    GX_SetViewport(x, y, (w > 640) ? 640 : w, h, 0, 1);
+    GX_SetScissor(x, y, (w > 640) ? 640 : w, h);

    // matrix, t, b, l, r, n, f
    guOrtho(proj, 0, h, 0, w, 0, 1);


My understanding is that GX_SetViewport and GX_SetScissor can be set to the EFB size (that is, we can consider w and h to be in pixels), and if we want to play with the aspect ratio we can play with the width parameter passed to guOrtho.

In other words, I would set leave the calls to GX_SetViewport and GX_SetScissor exactly as they were, then call OGC_get_aspect_ratio_dimensions right from within this function and call

const float ratio4_3 = 4.0f / 3.0f; guOrtho(proj, 0, h, 0, w * ratio / ratio4_3, 0, 1);

Of course, this needs to be checked. :-) The thing is, if you pass the same values to both functions (GX_SetViewport and guOrtho) you get a 1:1 mapping, which is not what we want for widescreen cases (or for any case where the ratio is not 4/3).

I gave up aspect correcting apps that aren't using 16:9
Fixing this here would cause issues, as I've showed before it makes VVVVVVV less wide than it should.
The whole guOrtho thing being a new var really felt like a hack, and I think leaving it as is is the best approach, especially since some apps resize the viewport twice every frame and it will distort the image more than it should if we do it

…ed on the height

Fancy2209 · 2025-02-09T21:42:50Z

I just tested Wii screen on my TV
692*460 is what worked, I have a component cable but I guess not good enough since I can't disable over scan (on LG TVs it's enabling Just Scan)
I guess I'll have to add an env var to optionally adjust for overscan :/

Fancy2209 · 2025-02-17T11:50:35Z

So since I can't just correct all viewports, what changes do I need to do appart from aspect ratio caching?

mardy · 2025-02-17T17:05:18Z

So since I can't just correct all viewports, what changes do I need to do appart from aspect ratio caching?

I've been quiet on the last few days because I've got several conflicting thoughts, and I'm not even sure what the original problem is (or maybe, there's more than one). I've wanted to test this myself, but I'm busy with some other stuff now, so I've to wait a few more days to get my hands on this. Meanwhile, if you have time, you might be able to answer this question: how does the TV detects aspect ratio? If the TV is set to auto-detect the aspect ratio, is it possible from the Wii to set the mode in such a way that the TV detects it with the aspect ratio we want (4:3 and 16:9 only, obviously)?

As for the cursor being cut, well, that is because you are shrinking the image in order to compensate for the stretching operated by the TV set. I think that your change which sets the interpolation mode to linear should fix it, doesn't it?

Fancy2209 · 2025-02-17T21:10:39Z

It's understandable to not have time
Let me answer your questions though
The issue was that if an app wanted to use widescreen, they couldn't, setting a window to 854 by 480 would just get cut off or get garbled. At one point I also tried to fix the issue that in 16:9 if an window wasn't a widescreen res it'd get streched, but I realized it wasn't worth it as it was a bit hacky and I wasn't happy with the results.
About the tv detection, it'll always be detected as 4:3, the Wii always outputs a 4:3 signal.

The cursor being set to linear made it be less noticeable but not 100% like it should, the homebrew channel cursor behaves much less weirdly

Fancy2209 · 2025-08-27T15:29:01Z

Any chance for a new review of this?

DacoTaco · 2025-08-27T15:43:34Z

Any chance for a new review of this?

that should be depended @mardy i think. they are basically the sdl->ogc expert here i think :p

mardy · 2025-08-27T16:14:16Z

src/video/ogc/SDL_ogcvideo.c

+    vmode->viWidth = VI_MAX_WIDTH_NTSC; // VI_MAX_WIDTH is the same for all regions
+    // set Center point
+    if (VI_FORMAT_FROM_MODE(vmode->viTVMode) == VI_PAL) {
+        vmode->viXOrigin = (VI_MAX_WIDTH_PAL - vmode->viWidth) / 2;
+        vmode->viYOrigin = (VI_MAX_HEIGHT_PAL - vmode->viHeight) / 2;
+    } else {
+        vmode->viXOrigin = (VI_MAX_WIDTH_NTSC - vmode->viWidth) / 2;
+        vmode->viYOrigin = (VI_MAX_HEIGHT_NTSC - vmode->viHeight) / 2;
+    }


This does not look correct: why are we setting the width to the max here? What if an application wants to have a 4:3 ratio and is therefore fine with viWidth and viHeight set to 640x480?

Or, actually, this is correct, but only if the Wii conf setting for the aspect ratio is set to 16:9. Do you agree, @Fancy2209 ?

Maybe? It's been so long I don't remeber why I did this change 😅

mardy · 2025-08-27T16:15:29Z

Any chance for a new review of this?

Oh, actually now I would have some time to test this, so thanks for the ping :-) By the way do you have some tests apps for this, or did you only try with VVVVVV?

Fancy2209 · 2025-08-27T19:22:44Z

Any chance for a new review of this?

Oh, actually now I would have some time to test this, so thanks for the ping :-) By the way do you have some tests apps for this, or did you only try with VVVVVV?

I used Neverball and had a Raylib Hello World sample working with it
Raylib and the sample build without changes using the SDL2 Backend as long as you disable raudio
Neverball worked but I had to add 854x480 as a option
mardy/neverball#1
though I think I based on the wrong branch as the one I modifed had mouse controls and not Accelerometer ones
VVVVVV I gave up on as correcting. It was getting Squished instead of beeing 4:3

Fancy2209 · 2025-08-28T19:59:47Z

Should I make a test app?

mardy · 2025-08-28T20:31:57Z

Should I make a test app?

That would be helpful indeed!

Fancy2209 · 2025-08-29T00:47:03Z

Should I make a test app?

That would be helpful indeed!

How would I allow the aspect ratio to be changed if that has to happen before init though?

mardy · 2025-08-29T18:10:28Z

Should I make a test app?

That would be helpful indeed!

How would I allow the aspect ratio to be changed if that has to happen before init though?

Just hardcode an aspect ratio, build the app, save it under a different name, change the aspect ratio in the code, build again :-) So we get two apps we can test.

Fancy2209 · 2025-08-29T18:24:11Z

Should I make a test app?

That would be helpful indeed!

How would I allow the aspect ratio to be changed if that has to happen before init though?

Just hardcode an aspect ratio, build the app, save it under a different name, change the aspect ratio in the code, build again :-) So we get two apps we can test.

ah I see
what ratios do you want?
4:3, 16:9 and 16:10?

mardy · 2025-08-30T05:42:23Z

ah I see what ratios do you want? 4:3, 16:9 and 16:10?

I would only care about 4:3 and 16:9, personally.

Fancy2209 · 2025-08-30T12:09:21Z

ah I see what ratios do you want? 4:3, 16:9 and 16:10?

I would only care about 4:3 and 16:9, personally.

Fair
Something is broken, when I set the aspect ratio and test on dolphin something breaks if I set the env var, addr2line doesn't say where though

Adds WIP Widescreen Support

8eaebcf

Fancy2209 force-pushed the Widescreen branch from 3c912b3 to 8eaebcf Compare February 4, 2025 15:41

Fancy2209 added 3 commits February 4, 2025 15:06

Fix Cursor

37151df

Add orthoWidth to draw init log

62191d5

Delete accidentally commited file

19e2688

Fancy2209 added 2 commits February 5, 2025 09:19

Fix orthoWidth in Renderer

e1f2bfd

Add missing include

6570d34

Fancy2209 marked this pull request as ready for review February 5, 2025 10:23

Fancy2209 added 3 commits February 5, 2025 16:38

Remove resizing from Renderer, doesn't work properly

4a73bb7

Fix SDL Renderer and OGC_set_viewport

fc69931

Stuff was setting the viewport and scissor to 854 Renderer now only adjusts projection if it's trying to set the viewport to 640*480 (this feels like not the intended way but I haven't found a better one)

Remove debug logging

ab85398

Fancy2209 changed the title ~~WIP: Widescreen Video Mode~~ [OGC] WIP: Wii Widescreen Feb 5, 2025

Fancy2209 mentioned this pull request Feb 5, 2025

Widescreen Support devkitPro/opengx#104

Closed

mardy requested changes Feb 5, 2025

View reviewed changes

Fancy2209 and others added 11 commits February 5, 2025 19:48

Update src/render/ogc/SDL_render_ogc.c

d6efcad

Co-authored-by: Alberto Mardegan <[email protected]>

Apply reviews

4dc34db

Merge branch 'Widescreen' of https://github.com/Fancy2209/SDL into Wi…

7afc872

…descreen

Close comment

016de5f

Expand comment

a5d6187

Fix build

7fc3f5c

Fix Widescreen Vide Mode Width Calculation

052e287

Fix mouse Widescreen Viewport

027d5d2

Revert ogcmouse changes, simply swap the names of screen_w and viewpo…

5219b8f

…rt_w

Assorted Fixes

d1b37b4

Fix 4:3 Make mouse actually unstreched on 16:9 Fix SDL_DisplayMode 16:9 width (for real this time)

Delete .vscode

412eb51

Fancy2209 requested a review from mardy February 5, 2025 23:43

Remove unused header

40e5e47

Fancy2209 changed the title ~~[OGC] WIP: Wii Widescreen~~ [OGC] Add support for Custom Aspect Ratios Feb 7, 2025

Add SDL_OGC_ASPECT_RATIO

984d25b

Because who doesn't want to make a Wii App that outputs at 21:9?

Fancy2209 requested a review from mardy February 7, 2025 22:19

mardy reviewed Feb 8, 2025

View reviewed changes

Make OGC_get_aspect_ratio return a float and scale the mouse only bas…

ad259a7

…ed on the height

Merge branch 'ogc-sdl-2.28' into Widescreen

a8beb9c

mardy reviewed Aug 27, 2025

View reviewed changes

Fancy2209 added 2 commits August 27, 2025 19:30

Fix rebasing

04d0218

Modify vmode only if not 4/3

9563a94

Uh oh!

[OGC] Add support for Custom Aspect Ratios #91

Are you sure you want to change the base?

[OGC] Add support for Custom Aspect Ratios #91

Uh oh!

Conversation

Fancy2209 commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Existing Issue(s)

Uh oh!

Fancy2209 commented Feb 4, 2025

Uh oh!

Fancy2209 commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fancy2209 commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fancy2209 commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mardy commented Feb 7, 2025

Uh oh!

Fancy2209 commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fancy2209 commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fancy2209 commented Feb 8, 2025

Uh oh!

mardy commented Feb 8, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fancy2209 Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mardy Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fancy2209 Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fancy2209 commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fancy2209 commented Feb 17, 2025

Uh oh!

mardy commented Feb 17, 2025

Uh oh!

Fancy2209 commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fancy2209 commented Aug 27, 2025

Uh oh!

DacoTaco commented Aug 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fancy2209 commented Feb 4, 2025 •

edited

Loading

Fancy2209 commented Feb 5, 2025 •

edited

Loading

Fancy2209 commented Feb 5, 2025 •

edited

Loading

Fancy2209 commented Feb 6, 2025 •

edited

Loading

Fancy2209 commented Feb 7, 2025 •

edited

Loading

Fancy2209 commented Feb 7, 2025 •

edited

Loading

Fancy2209 Feb 8, 2025 •

edited

Loading

mardy Feb 8, 2025 •

edited

Loading

Fancy2209 Feb 8, 2025 •

edited

Loading

Fancy2209 commented Feb 9, 2025 •

edited

Loading

Fancy2209 commented Feb 17, 2025 •

edited

Loading

Fancy2209 commented Aug 27, 2025 •

edited

Loading