-
Notifications
You must be signed in to change notification settings - Fork 56
feat: app list segregation and chart store #2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the application list routing to segregate Devtron apps from infrastructure apps (Helm, ArgoCD, FluxCD) and moves the Chart Store from Application Management to Infrastructure Management.
Key Changes:
- Separated app lists into Devtron Applications (under Application Management) and infrastructure apps including Helm, ArgoCD, and FluxCD (under Infrastructure Management)
- Relocated Chart Store from Application Management to Infrastructure Management
- Updated breadcrumb configuration to use infrastructure management context for relevant pages
Reviewed Changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/service.types.ts | Removed unused AppRouterType interface |
| src/config/routes.ts | Moved chart store URLs to infrastructure management and updated app list path generation |
| src/components/v2/headers/EAHeader.component.tsx | Updated breadcrumb to use infrastructure management context |
| src/components/v2/headers/ChartHeader.component.tsx | Updated breadcrumbs and converted Helm Apps to a proper link component |
| src/components/v2/appDetails/sourceInfo/environmentStatus/ChartUsedCard.tsx | Updated chart store discovery URL to infrastructure management |
| src/components/onboardingGuide/OnboardingGuide.tsx | Updated URLs to use common URL constants |
| src/components/externalArgoApps/ExternalArgoApp.tsx | Simplified redirect URL and cleaned up formatting |
| src/components/external-apps/ExternalApps.tsx | Updated redirect URL to use constant |
| src/components/dockerRegistry/Docker.tsx | Updated chart store URLs to infrastructure management |
| src/components/common/navigation/NavigationRoutes.tsx | Added InfraAppsRouter and removed router props |
| src/components/common/navigation/Navigation.tsx | Updated navigation icons |
| src/components/common/navigation/NavRoutes.components.tsx | Refactored routing logic to separate Devtron and infrastructure apps |
| src/components/checkList/*.tsx | Updated URLs and imports to use common constants |
| src/components/charts/**/*.tsx | Updated breadcrumbs and URLs to infrastructure management |
| src/components/app/list-new/*.tsx | Major refactoring to support app type segregation with infrastructure management types |
| src/components/Navigation/*.tsx | Updated navigation structure and icons |
| src/components/Jobs/JobList/JobsList.tsx | Updated header prop from isJobView to viewType |
| src/Pages/**/*.tsx | Updated URLs and breadcrumbs to infrastructure management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls verify applist filter chip and command bar most recent redirections
8711114
|



Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2649
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: