Skip to content

Conversation

@arunjaindev
Copy link
Contributor

@arunjaindev arunjaindev commented Oct 21, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2649

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Oct 21, 2025
@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Oct 21, 2025
@arunjaindev arunjaindev requested a review from Copilot October 21, 2025 15:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the application list routing to segregate Devtron apps from infrastructure apps (Helm, ArgoCD, FluxCD) and moves the Chart Store from Application Management to Infrastructure Management.

Key Changes:

  • Separated app lists into Devtron Applications (under Application Management) and infrastructure apps including Helm, ArgoCD, and FluxCD (under Infrastructure Management)
  • Relocated Chart Store from Application Management to Infrastructure Management
  • Updated breadcrumb configuration to use infrastructure management context for relevant pages

Reviewed Changes

Copilot reviewed 41 out of 42 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/services/service.types.ts Removed unused AppRouterType interface
src/config/routes.ts Moved chart store URLs to infrastructure management and updated app list path generation
src/components/v2/headers/EAHeader.component.tsx Updated breadcrumb to use infrastructure management context
src/components/v2/headers/ChartHeader.component.tsx Updated breadcrumbs and converted Helm Apps to a proper link component
src/components/v2/appDetails/sourceInfo/environmentStatus/ChartUsedCard.tsx Updated chart store discovery URL to infrastructure management
src/components/onboardingGuide/OnboardingGuide.tsx Updated URLs to use common URL constants
src/components/externalArgoApps/ExternalArgoApp.tsx Simplified redirect URL and cleaned up formatting
src/components/external-apps/ExternalApps.tsx Updated redirect URL to use constant
src/components/dockerRegistry/Docker.tsx Updated chart store URLs to infrastructure management
src/components/common/navigation/NavigationRoutes.tsx Added InfraAppsRouter and removed router props
src/components/common/navigation/Navigation.tsx Updated navigation icons
src/components/common/navigation/NavRoutes.components.tsx Refactored routing logic to separate Devtron and infrastructure apps
src/components/checkList/*.tsx Updated URLs and imports to use common constants
src/components/charts/**/*.tsx Updated breadcrumbs and URLs to infrastructure management
src/components/app/list-new/*.tsx Major refactoring to support app type segregation with infrastructure management types
src/components/Navigation/*.tsx Updated navigation structure and icons
src/components/Jobs/JobList/JobsList.tsx Updated header prop from isJobView to viewType
src/Pages/**/*.tsx Updated URLs and breadcrumbs to infrastructure management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@AbhishekA1509 AbhishekA1509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls verify applist filter chip and command bar most recent redirections

AbhishekA1509
AbhishekA1509 previously approved these changes Oct 23, 2025
vivek-devtron
vivek-devtron previously approved these changes Oct 27, 2025
@sonarqubecloud
Copy link

@arunjaindev arunjaindev merged commit fa5d2e4 into kubecon-2025 Oct 30, 2025
6 checks passed
@arunjaindev arunjaindev deleted the feat/segregate-listing branch October 30, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:Ready-to-Review PR:Ready-to-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants