feat: security overview #2974
feat: security overview #2974
Conversation
arunjaindev
requested review from
vikramdevtron and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
github-actions
bot
added
the
PR:Issue-verification-failed
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the @devtron-labs/devtron-fe-common-lib package from version 1.20.6-alpha-31 to 1.20.6-beta-2 and refactors the security center module to leverage new utilities and components from the updated common library.
Key changes include:
- Upgrading the common library package version
- Migrating security center routes and breadcrumbs to common library constants
- Refactoring the security scans UI to use
GroupedFilterSelectPickerand display multiple severity badges - Restructuring component layouts with consistent wrapper styling
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates common library dependency to 1.20.6-beta-2 |
| yarn.lock | Reflects package lock changes for updated dependency |
| src/config/routes.ts | Removes local security route constants now available in common library |
| src/components/security/security.util.tsx | Refactors breadcrumb generation to use getSecurityCenterBreadcrumb from common library |
| src/components/security/security.scss | Removes unused page header and search styling |
| src/components/security/constants.ts | Updates imports to use security center URLs from common library |
| src/components/security/SecurityScansTab/utils.tsx | Removes unused getSeverityFilterLabelFromValue function; updates getSeverityWithCount to return multiple badges instead of first match only |
| src/components/security/SecurityScansTab/types.tsx | Removes unused SeverityMapping enum |
| src/components/security/SecurityScansTab/constants.tsx | Adds configuration for grouped filter select picker |
| src/components/security/SecurityScansTab/SecurityScansTab.tsx | Major refactor: replaces multiple FilterSelectPicker components with GroupedFilterSelectPicker, updates to display multiple severity badges, adds wrapper div, refactors filter update handlers |
| src/components/security/SecurityPolicyEdit.tsx | Updates security policy route references to use common library constants |
| src/components/security/SecurityPolicyCluster.tsx | Removes unused React and Search icon imports |
| src/components/security/SecurityPolicyApp.tsx | Removes unused React and Search icon imports |
| src/components/security/SecurityPoliciesTab.tsx | Adds wrapper div and fixes code formatting |
| src/components/security/Security.tsx | Restructures routing to support SecurityCenterOverview component and updates route references |
| src/components/Navigation/constants.ts | Updates navigation URLs to use common library constants and enables security center overview link |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: