-
Notifications
You must be signed in to change notification settings - Fork 6
feat: security overview #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n-fe-common-lib into feat/security-overview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for semi-pie charts (half-circle/gauge charts) to the Chart component, introduces new security-related icons and constants, fixes a bug in SelectPickerTextArea for creatable options, and performs module reorganization in the SecurityCenter and InfrastructureManagement sections.
- Added
semiPiechart type with optional center text rendering capability for creating gauge-style visualizations - Introduced security severity mapping constants and three new security icons (vulnerability, fixable, not-fixable)
- Fixed SelectPickerTextArea to properly handle blur events when in creatable mode
Reviewed Changes
Copilot reviewed 22 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Shared/Components/SelectPicker/SelectPickerTextArea.component.tsx | Moved handleCreateOption function before its usage and fixed blur event handling for creatable mode |
| src/Shared/Components/Security/index.tsx | Exported SEVERITY_LABEL_MAP constant |
| src/Shared/Components/Security/constants.tsx | Added SEVERITY_LABEL_MAP mapping Severity enum to display strings |
| src/Shared/Components/Icon/Icon.tsx | Registered three new security-related icons |
| src/Shared/Components/Charts/utils.tsx | Added semiPie support across chart utilities with improved type safety for area chart datasets |
| src/Shared/Components/Charts/types.ts | Extended type definitions to support semiPie chart type and centerText configuration |
| src/Shared/Components/Charts/plugins.ts | Added drawCenterText plugin for rendering text in chart center |
| src/Shared/Components/Charts/index.ts | Exported CenterTextConfig type |
| src/Shared/Components/Charts/Chart.component.tsx | Integrated semiPie support with centerText plugin and updated documentation |
| src/Pages-Devtron-2.0/SecurityCenter/* | Added SecurityCenterIcon component and breadcrumb utility, reorganized exports |
| src/Pages-Devtron-2.0/InfrastructureManagement/* | Removed empty Overview exports |
| src/Common/Constants.ts | Added three new Security Center URL constants |
| src/Assets/IconV2/* | Added three new SVG icon files |
| package.json & package-lock.json | Version bump to 1.20.6-beta-2 |
Comments suppressed due to low confidence (2)
src/Shared/Components/Charts/Chart.component.tsx:150
- The example documentation shows
borderColorfor line charts, but based on the types (SimpleDatasetForLineAndArea), the property should becolor, notborderColor.
* borderColor: 'SkyBlue500'
src/Shared/Components/Charts/Chart.component.tsx:163
- The example documentation shows
backgroundColorfor stacked bar charts, but based on the types (SimpleDataset), the property should becolor, notbackgroundColor.
* backgroundColor: 'SkyBlue600'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…n-fe-common-lib into feat/security-overview
245f125
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist