Skip to content

Conversation

@arunjaindev
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@AbhishekA1509 AbhishekA1509 requested a review from Copilot October 31, 2025 12:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for semi-pie charts (half-circle/gauge charts) to the Chart component, introduces new security-related icons and constants, fixes a bug in SelectPickerTextArea for creatable options, and performs module reorganization in the SecurityCenter and InfrastructureManagement sections.

  • Added semiPie chart type with optional center text rendering capability for creating gauge-style visualizations
  • Introduced security severity mapping constants and three new security icons (vulnerability, fixable, not-fixable)
  • Fixed SelectPickerTextArea to properly handle blur events when in creatable mode

Reviewed Changes

Copilot reviewed 22 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Shared/Components/SelectPicker/SelectPickerTextArea.component.tsx Moved handleCreateOption function before its usage and fixed blur event handling for creatable mode
src/Shared/Components/Security/index.tsx Exported SEVERITY_LABEL_MAP constant
src/Shared/Components/Security/constants.tsx Added SEVERITY_LABEL_MAP mapping Severity enum to display strings
src/Shared/Components/Icon/Icon.tsx Registered three new security-related icons
src/Shared/Components/Charts/utils.tsx Added semiPie support across chart utilities with improved type safety for area chart datasets
src/Shared/Components/Charts/types.ts Extended type definitions to support semiPie chart type and centerText configuration
src/Shared/Components/Charts/plugins.ts Added drawCenterText plugin for rendering text in chart center
src/Shared/Components/Charts/index.ts Exported CenterTextConfig type
src/Shared/Components/Charts/Chart.component.tsx Integrated semiPie support with centerText plugin and updated documentation
src/Pages-Devtron-2.0/SecurityCenter/* Added SecurityCenterIcon component and breadcrumb utility, reorganized exports
src/Pages-Devtron-2.0/InfrastructureManagement/* Removed empty Overview exports
src/Common/Constants.ts Added three new Security Center URL constants
src/Assets/IconV2/* Added three new SVG icon files
package.json & package-lock.json Version bump to 1.20.6-beta-2
Comments suppressed due to low confidence (2)

src/Shared/Components/Charts/Chart.component.tsx:150

  • The example documentation shows borderColor for line charts, but based on the types (SimpleDatasetForLineAndArea), the property should be color, not borderColor.
 *     borderColor: 'SkyBlue500'

src/Shared/Components/Charts/Chart.component.tsx:163

  • The example documentation shows backgroundColor for stacked bar charts, but based on the types (SimpleDataset), the property should be color, not backgroundColor.
 *       backgroundColor: 'SkyBlue600'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AbhishekA1509
AbhishekA1509 previously approved these changes Nov 3, 2025
vivek-devtron
vivek-devtron previously approved these changes Nov 4, 2025
@arunjaindev arunjaindev merged commit a6358e7 into kubecon-2025 Nov 6, 2025
3 checks passed
@arunjaindev arunjaindev deleted the feat/security-overview branch November 6, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants