Add test vectors for mocked classes #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @dlongley @msporny @dmitrizagidulin trying to add test vector generation code to this code base, before attempting to reimplement the client for the SDS. |
|
partially blocked by digitalbazaar/http-signature-zcap-invoke#11 |
|
@OR13, ack, we're looking into the partial blocker. |
|
This can be merged, and I can circle back to add better tests for http invocation if thats desirable. |
|
@aljones15 -- we need to run these test vectors against our current implementations to see if everything checks out. If it does, we can merge this -- if not, we should see what needs to be tweaked (one way or the other). I don't want to push test vectors forward that cause more people to have bugs/differences that shouldn't be there. |
dlongley
reviewed
Oct 24, 2020
Co-authored-by: Dave Longley <[email protected]>
|
any movement on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to establish test vectors for EDVs we need to extract the string values from the mocked classes, and the expected inputs and outputs associated with hmac and ed25519 sign.
This PR adds JSON files for establishing conformance for mocked classes.