Skip to content

fix 971: Server always downgrades TLS to v1.0 #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix 971: Server always downgrades TLS to v1.0 #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,7 @@ tls.handleClientHello = function(c, record, length) {
} else {
// use highest compatible minor version
var version;
for(var i = 1; i < tls.SupportedVersions.length; ++i) {
for(var i = 0; i < tls.SupportedVersions.length; ++i) {
version = tls.SupportedVersions[i];
if(version.minor <= msg.version.minor) {
break;
Expand Down
192 changes: 139 additions & 53 deletions tests/unit/tls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,61 @@ require('../../lib/util');

(function() {
describe('tls', function() {

function createCertificate(cn, data) {
var keys = forge.pki.rsa.generateKeyPair(512);
var cert = forge.pki.createCertificate();
cert.publicKey = keys.publicKey;
cert.serialNumber = '01';
cert.validity.notBefore = new Date();
cert.validity.notAfter = new Date();
cert.validity.notAfter.setFullYear(
cert.validity.notBefore.getFullYear() + 1);
var attrs = [{
name: 'commonName',
value: cn
}, {
name: 'countryName',
value: 'US'
}, {
shortName: 'ST',
value: 'Virginia'
}, {
name: 'localityName',
value: 'Blacksburg'
}, {
name: 'organizationName',
value: 'Test'
}, {
shortName: 'OU',
value: 'Test'
}];
cert.setSubject(attrs);
cert.setIssuer(attrs);
cert.setExtensions([{
name: 'basicConstraints',
cA: true
}, {
name: 'keyUsage',
keyCertSign: true,
digitalSignature: true,
nonRepudiation: true,
keyEncipherment: true,
dataEncipherment: true
}, {
name: 'subjectAltName',
altNames: [{
type: 6, // URI
value: 'https://myuri.com/webid#me'
}]
}]);
cert.sign(keys.privateKey);
data[cn] = {
cert: forge.pki.certificateToPem(cert),
privateKey: forge.pki.privateKeyToPem(keys.privateKey)
};
}

it('should test TLS 1.0 PRF', function() {
// Note: This test vector is originally from:
// http://www.imc.org/ietf-tls/mail-archive/msg01589.html
Expand Down Expand Up @@ -117,59 +172,90 @@ require('../../lib/util');

end.client.handshake();

function createCertificate(cn, data) {
var keys = forge.pki.rsa.generateKeyPair(512);
var cert = forge.pki.createCertificate();
cert.publicKey = keys.publicKey;
cert.serialNumber = '01';
cert.validity.notBefore = new Date();
cert.validity.notAfter = new Date();
cert.validity.notAfter.setFullYear(
cert.validity.notBefore.getFullYear() + 1);
var attrs = [{
name: 'commonName',
value: cn
}, {
name: 'countryName',
value: 'US'
}, {
shortName: 'ST',
value: 'Virginia'
}, {
name: 'localityName',
value: 'Blacksburg'
}, {
name: 'organizationName',
value: 'Test'
}, {
shortName: 'OU',
value: 'Test'
}];
cert.setSubject(attrs);
cert.setIssuer(attrs);
cert.setExtensions([{
name: 'basicConstraints',
cA: true
}, {
name: 'keyUsage',
keyCertSign: true,
digitalSignature: true,
nonRepudiation: true,
keyEncipherment: true,
dataEncipherment: true
}, {
name: 'subjectAltName',
altNames: [{
type: 6, // URI
value: 'https://myuri.com/webid#me'
}]
}]);
cert.sign(keys.privateKey);
data[cn] = {
cert: forge.pki.certificateToPem(cert),
privateKey: forge.pki.privateKeyToPem(keys.privateKey)
};
}
});

it('should use TLS v1.1 by default and not downgrade to 1.0 if client requested 1.1', function(done) {
/* This test covers a bug in which TLS server upon reception ClientHello with TLS v1.1
downgraded TLS to 1.0 for no reason.
*/
var end = {};
var data = {};

createCertificate('server', data);
createCertificate('client', data);
data.client.connection = {};
data.server.connection = {};

end.client = forge.tls.createConnection({
server: false,
caStore: [data.server.cert],
sessionCache: {},
cipherSuites: [
forge.tls.CipherSuites.TLS_RSA_WITH_AES_128_CBC_SHA,
forge.tls.CipherSuites.TLS_RSA_WITH_AES_256_CBC_SHA],
virtualHost: 'server',
verify: function(c, verified, depth, certs) {
return true;
},
connected: function(c) {
data.client.version = c.version;
},
getCertificate: function(c, hint) {
return data.client.cert;
},
getPrivateKey: function(c, cert) {
return data.client.privateKey;
},
tlsDataReady: function(c) {
end.server.process(c.tlsData.getBytes());
},
dataReady: function(c) {
},
closed: function(c) {
},
error: function(c, error) {
ASSERT.equal(error.message, undefined);
}
});

end.server = forge.tls.createConnection({
server: true,
caStore: [data.client.cert],
sessionCache: {},
cipherSuites: [
forge.tls.CipherSuites.TLS_RSA_WITH_AES_128_CBC_SHA,
forge.tls.CipherSuites.TLS_RSA_WITH_AES_256_CBC_SHA],
connected: function(c) {
data.server.version = c.version;
c.close();
},
verifyClient: true,
verify: function(c, verified, depth, certs) {
return true;
},
getCertificate: function(c, hint) {
return data.server.cert;
},
getPrivateKey: function(c, cert) {
return data.server.privateKey;
},
tlsDataReady: function(c) {
end.client.process(c.tlsData.getBytes());
},
dataReady: function(c) {
},
closed: function(c) {
ASSERT.deepEqual(data.client.version, forge.tls.Versions.TLS_1_1);
ASSERT.deepEqual(data.server.version, forge.tls.Versions.TLS_1_1);
done();
},
error: function(c, error) {
ASSERT.equal(error.message, undefined);
}
});

end.client.handshake();

});
});
})();