Skip to content

WIP: Uncertainties usdf #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

WIP: Uncertainties usdf #53

wants to merge 15 commits into from

Conversation

wilsonbb
Copy link
Collaborator

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@wilsonbb wilsonbb mentioned this pull request Mar 21, 2025
Open
wilsonbb
wilsonbb commented Mar 25, 2025
View reviewed changes
src/kbmod_wf/wu_to_uncertainties_workflow.py
for r in results:
# TODO Make UUIDs required
uuid = r["uuid"] if "uuid" in r.table.colnames else -1
samples = explorer.evaluate_around_linear_trajectory(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in check for velocity 0

src/kbmod_wf/wu_to_uncertainties_workflow.py
Comment on lines +158 to +161
"likelihood": likelihoods,
"p1ra": p1ra,
"p1dec": p1dec,
"p2ra": p2ra,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the generated x's and y's to the table for debugging purposes

wilsonbb and others added 13 commits March 25, 2025 14:29
@wilsonbb
Fix uncertainty workflow import
fbe9555
@wilsonbb
Switch WorkUnit.heliocentric_distance to WorkUnit.barycentric_distance (
fae703b 
#54) (#55)
@ColinOrionChandler @wilsonbb
updated usdf config (#56)
f7bd5bd 
Updated the configuration as needed
@ColinOrionChandler @wilsonbb
Increased max block size for the various partitions. (#58)
72cc308 
Co-authored-by: Colin Orion Chandler <[email protected]>
@wilsonbb
Make Parsl Robust to Workflow Exceptions (#59)
5bf19e9 
* Remove 42.0 au as a default guess distance

* Catch exceptions from kbmod search futures

* When reprojecting WorkUnits, use overwrite=True by default
@wilsonbb
Add option to cleanup sharded WorkUnit after search
940d90f
@wilsonbb
Updated files
a7fb13e
@wilsonbb
Remove date from Parsl workflow run directory (#61)
4be91a0
@ColinOrionChandler @wilsonbb
Added parsl config scripts for USDF (#63)
af4f8ad 
Co-authored-by: Colin Orion Chandler <[email protected]>
@ColinOrionChandler @wilsonbb
automatic detection of usdf; new Parsl fixes (#64)
dc4a8ed 
* automatic detection of usdf; new Parsl fixes

* automated correct location of generic files

* fixed Klone config to match new Parsl

---------

Co-authored-by: Colin Orion Chandler <[email protected]>
Co-authored-by: Colin Orion Chandler <[email protected]>
@ColinOrionChandler @wilsonbb
One node to rule them all (#65)
353b91b 
* Adding whole-node approach for GPU work.

* Rest of the files

---------

Co-authored-by: Colin Orion Chandler <[email protected]>
@wilsonbb
Add flag to disorder/fuzz the obstimes of a WorkUnit (#66)
6d08418
@wilsonbb
Merge branch 'main' into uncertainties_USDF
903178f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilsonbb @ColinOrionChandler