Mocking/initial #567
Draft
Mocking/initial #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoBektesevic
force-pushed
the
mocking/initial
branch
from
d797271 to
7bbdef9
Compare
DinoBektesevic
force-pushed
the
mocking/initial
branch
from
7bbdef9 to
f115580
Compare
DinoBektesevic
force-pushed
the
mocking/initial
branch
from
8c9ae11 to
b2d2697
Compare
…object injection.
Join the Static and Mutable headers together. This halves the code length, but then the validation method triples it... Clean up and replace Static and Mutable with HeaderFactory. Move Header base skeleton generators to HeaderFactory from HDUList. Clean up their use in fits.py. Compute image size from NAXIS keywords when creating base Header skeletons. Move image rendering logic from HDUList to DataFactory. Clean up fits.py after the change. Fix EmptyFits generation. Fix SimpleImage noise issue. Clean up imports. Blacken.
DinoBektesevic
force-pushed
the
mocking/initial
branch
from
b2d2697 to
1b81849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config headaches. the data generation stuff is pretty good though. Trimmed out all the fat, missing docstrings, but free feel to read/comment on the code as I'm adding them and tests.
Will make a full PR and request a review once I add the docstrings.