types(core): use result types instead of direct types #11140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Drafting until the discord-api-types release. |
Jiralite
previously requested changes
Oct 5, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11140 +/- ##
==========================================
+ Coverage 44.34% 44.39% +0.05%
==========================================
Files 315 315
Lines 18155 18133 -22
Branches 1805 1805
==========================================
Hits 8051 8051
+ Misses 10092 10070 -22
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please resolve conflicts! |
vladfrangu
force-pushed
the
types/use-return-types-instead-of-direct-types
branch
from
ed52cd1 to
66241cc
Compare
almeidx
reviewed
Oct 7, 2025
Jiralite
reviewed
Oct 8, 2025
Jiralite
approved these changes
Oct 8, 2025
fix: import pains chore: apply suggestion from review Co-authored-by: Almeida <[email protected]> chore: fmt script chore: requested change
vladfrangu
force-pushed
the
types/use-return-types-instead-of-direct-types
branch
from
ca625d6 to
1fcc735
Compare
Jiralite
reviewed
Oct 8, 2025
|
|
That's an unstable/undocumented route so that's fine. |
almeidx
reviewed
Oct 8, 2025
almeidx
approved these changes
Oct 8, 2025
sdanialraza
approved these changes
Oct 8, 2025
Qjuh
approved these changes
Oct 11, 2025
SpaceEEC
approved these changes
Oct 24, 2025
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
kodiakhq
bot
deleted the
types/use-return-types-instead-of-direct-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Just fixes some type references. WIll PR to DTypes to fix the thread return type being a generic channel instead of a specific type
Needs
Status and versioning classification: