Skip to content

Fix: Remove field_class from div-wrapper in FormActions #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: Remove field_class from div-wrapper in FormActions #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e50ac88
Fix: Remove field_class from div-wrapper in FormActions
SnejPro Dec 31, 2024
8a2d207
Update test_formactions.html
SnejPro Dec 31, 2024
1236f22
Fix: test_formactions.html
SnejPro Dec 31, 2024
98ed98e
Update test_formactions.html
SnejPro Dec 31, 2024
0e04fd7
Fix: test_layout_objects.py
SnejPro Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crispy_bootstrap5/templates/bootstrap5/layout/formactions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div
{% if formactions.flat_attrs %}{{ formactions.flat_attrs }}{% endif %}
class="mb-3{% if 'form-horizontal' in form_class %} row{% endif %} {{ formactions.css_class|default:'' }} {{ field_class }}"
class="mb-3{% if 'form-horizontal' in form_class %} row{% endif %} {{ formactions.css_class|default:'' }}"
{% if formactions.id %} id="{{ formactions.id }}"{% endif %}>
{% if label_class %}
<div class="aab {{ label_class }}"></div>
Expand Down
2 changes: 1 addition & 1 deletion tests/results/test_formactions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div
test="formactions-test"
class="mb-3 formactions-test-class field-class"
class="mb-3 formactions-test-class"
id="formactions-test-id">
<div class="field-class">
<b>test</b>
Expand Down
4 changes: 2 additions & 2 deletions tests/test_layout_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ def test_formactions(self):
),
)

assert 'class="mb-3 "' in render_crispy_form(test_form)
assert 'class="mb-3 "' in render_crispy_form(test_form)

def test_formactions_attrs(self):
test_form = SampleForm()
Expand Down Expand Up @@ -693,5 +693,5 @@ def test_formactions_horizontal_form(self):
),
)

expected_class = 'class="mb-3 row formactions-test-class "'
expected_class = 'class="mb-3 row formactions-test-class"'
assert expected_class in render_crispy_form(test_form)