Skip to content

Fixed Handled error in OAuth2ExtraTokenMiddleware when authheader has Bearer with no token-string following up #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+8 −2
Open

Fixed Handled error in OAuth2ExtraTokenMiddleware when authheader has Bearer with no token-string following up #1502

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6aa1da2
fixed: Handled error when authheader is `Bearer ` with no token-strin…
Tuhin-thinks Sep 21, 2024
38faf16
included my name in authors
Tuhin-thinks Sep 21, 2024
f87c5f4
changed CHANGELOG.md
Tuhin-thinks Sep 21, 2024
f209f10
Merge branch 'master' into bug/1496/unhandled-empty-bearer-token-exce…
Tuhin-thinks Oct 2, 2024
6465b1d
[pre-commit.ci] pre-commit autoupdate (#1504)
pre-commit-ci[bot] Sep 23, 2024
574208b
Bump rollup from 4.21.3 to 4.22.4 in /tests/app/rp (#1505)
dependabot[bot] Sep 24, 2024
63df0ae
[pre-commit.ci] pre-commit autoupdate (#1509)
pre-commit-ci[bot] Sep 30, 2024
3f9795d
feat: allowed_origins and redirect_uris wildcards (#1508)
dopry Oct 2, 2024
ac5aacd
Merge branch 'bug/1496/unhandled-empty-bearer-token-exception' of htt…
Tuhin-thinks Oct 2, 2024
d7ff603
changed middleware.py to optimize usage of variables.
Tuhin-thinks Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,3 +122,4 @@ Wouter Klein Heerenbrink
Yaroslav Halchenko
Yuri Savin
Miriam Forner
Tuhin Mitra
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Security
-->

## [unreleased]
### Fixed
* #1496 Fix error when Bearer token string is empty but preceded by `Bearer` keyword.

## [3.0.1] - 2024-09-07
### Fixed
* #1491 Fix migration error when there are pre-existing Access Tokens.
Expand Down
4 changes: 2 additions & 2 deletions oauth2_provider/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ def __init__(self, get_response):

def __call__(self, request):
authheader = request.META.get("HTTP_AUTHORIZATION", "")
if authheader.startswith("Bearer"):
tokenstring = authheader.split()[1]
if authheader.startswith("Bearer") and len(authheader.split(maxsplit=1)) == 2:
tokenstring = authheader.split(maxsplit=1)[1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest not calling split() twice:

Suggested change
if authheader.startswith("Bearer") and len(authheader.split(maxsplit=1)) == 2:
tokenstring = authheader.split(maxsplit=1)[1]
splits = autheader.split(maxsplit=1)
if authheader.startswith("Bearer") and len(splits) == 2:
tokenstring = splits[1]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion, I will make the changes by today!

AccessToken = get_access_token_model()
try:
token_checksum = hashlib.sha256(tokenstring.encode("utf-8")).hexdigest()
Expand Down
Loading