fix #2079 github minutes repo link added #2111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Hi Could you please anyone have any comment on this PR ? I though I have fixed the issue and is ready for review and merge. |
|
good job |
|
Hi, is this PR okay to merge ? If I need to workout anything more to make it ready for merge, let me know. |
SaptakS
requested changes
Aug 18, 2025
| @@ -26,6 +26,7 @@ <h3>About the foundation</h3> | |||
| <li><a href="/foundation/conferences/">Organizing a Django conference</a></li> | |||
| </ul> | |||
| <h3>{% translate "Latest DSF meeting minutes" %}</h3> | |||
| <p> {% translate "The minutes from May 2025 onwards are stored in the repo https://github.com/django/dsf-minutes" %} </p> | |||
There was a problem hiding this comment.
Suggested change
| <p> {% translate "The minutes from May 2025 onwards are stored in the repo https://github.com/django/dsf-minutes" %} </p> | |
| <p> {% translate "The minutes from May 2025 onwards are stored in the repo " %} | |
| <a href="https://github.com/django/dsf-minutes">https://github.com/django/dsf-minutes</a> | |
| </p> |
I think we should maybe put the github repo inside an anchor tag so it shows up as a link? Thoughts?
| @@ -11,11 +11,13 @@ | |||
| {% block content %} | |||
| <h1>{% translate "Meeting minutes archive" %}</h1> | |||
|
|
|||
| <p>{% translate "Select a year to view meeting minutes:" %}</p> | |||
| <p>{% translate "The minutes from May 2025 onwards are stored in the repo https://github.com/django/dsf-minutes" %} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.