-
-
Notifications
You must be signed in to change notification settings - Fork 236
refactor integration tests (part 1) #3071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
ldc2 on alpine is configured to use the lld linker, however, the lld package is not pulled in as a dependency. Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
Signed-off-by: Andrei Horodniceanu <[email protected]>
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5265672 bin/dub
rough build time=61s Full build output
|
Signed-off-by: Andrei Horodniceanu <[email protected]>
ping @Geod24 |
@the-horo : Thanks for the ping. Why are the tests under |
I understood that you want the refactoring to come in smaller batches. Since the new tests have stricter requirements (e.g. for One particularity is that it would slightly difficult, assuming the latter approach (so a new directory for the tests, just like I did), to also remove the older tests, since I would have to dig through what each test depends on, and move these graphs of tests in a single PR. Maybe it's possible or at least not that difficult. |
A smaller extract of #3064. I've tried to keep the old tests running so that means that the refactor would only be adding tests, and we will be left to remove the old ones at a later time when the refactor finishes. I've also tried to keep CI usable, running all of the old tests alongside the newer ones.
@Geod24 is this in the range of smaller but no so small PR, I don't expect problems if you want me to increase or decrease the number of commits per PR.