Orchestrator course #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anair123
reviewed
Sep 3, 2025
|
|
||
| github_source = rest_api_source(config) | ||
|
|
||
| # pipeline = dlt.pipeline( |
There was a problem hiding this comment.
Let's uncomment this and put it in under a main check (if name == "main"). I (and the users) can run the pipeline locally that way.
| @@ -0,0 +1,80 @@ | |||
| import dlt | |||
| from dlt.sources.rest_api import RESTAPIConfig, rest_api_source | |||
|
|
|||
There was a problem hiding this comment.
Pendulum needs to be imported
|
|
||
| # pipeline = dlt.pipeline( | ||
| # pipeline_name="github_repos_issues", | ||
| # destination="duckdb", |
There was a problem hiding this comment.
We'll be using bigquery as our destination instead of duckdb
| @@ -0,0 +1,80 @@ | |||
| import dlt | |||
There was a problem hiding this comment.
Not relevant to this script itself, but I am wondering if there should also be a README file with instructions on running the script. We can give installation commands and also provide links to the dlt docs when relevant.
The script looks and works great, but it might be hard for users to navigate it without a guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented backfill and incremental loading.