Ignore DOCKER_AUTH_CONFIG without opt-in on Gitlab CI
#6171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hot-fix that prevents using the `DOCKER_AUTH_CONFIG` env-var
as a credential helper when running in Gitlab CI (determined by
`GITLAB_CI` environment variable).
An explicit setting controlling this behavior is available through the
`auth_config_order` feature flag in the Docker CLI config (and
`DOCKER_AUTH_ORDER` environment variable that takes precedence over the
feature flag value).
It accepts a comma separated "config" and "env" strings which determine
the order.
Currently, possible values are:
- "config,env" - prefer the auth from config.json first
- "env,config" - prefer the auth from `DOCKER_AUTH_CONFIG`
```json ~/.docker/config.json
{
...,
"features": {
"auth_config_order": "config,env"
}
}
```
Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
added
kind/bugfix
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hot-fix that prevents using the
DOCKER_AUTH_CONFIGenv-var as a credential helper when running in Gitlab CI (determined byGITLAB_CIenvironment variable).An explicit setting controlling this behavior is available through the
auth_config_orderfeature flag in the Docker CLI config (andDOCKER_AUTH_ORDERenvironment variable that takes precedence over the feature flag value).It accepts a comma separated "config" and "env" strings which determine the order.
Currently, possible values are:
DOCKER_AUTH_CONFIG{ ..., "features": { "auth_config_order": "config,env" } }- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)