rootless: Automatically populate TEST/STABLE version #532
Conversation
vvoland
force-pushed
the
rootless-auto-versions
branch
8 times, most recently
from
773fa0a to
59cd1e3
Compare
austinvazquez
left a comment
austinvazquez
left a comment
There was a problem hiding this comment.
LGTM, just a quick comment to double check the two new values are not currently used in install.sh is intentional.
| LOAD_SCRIPT_STABLE_LATEST='$(STABLE_LATEST)' \ | ||
| LOAD_SCRIPT_TEST_LATEST='$(TEST_LATEST)' \ |
There was a problem hiding this comment.
I assume these are here for completeness and not actually referenced in install.sh.
There was a problem hiding this comment.
Yeah they're not used right now
vvoland
force-pushed
the
rootless-auto-versions
branch
from
59cd1e3 to
e60e2b2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR automates version management for Docker installation scripts by introducing a script that dynamically fetches the latest Docker versions from the moby/moby GitHub releases API instead of hardcoding them.
- Adds
scripts/get-version.shto fetch latest stable and test versions from GitHub releases - Updates
Makefileto call the version script and inject version variables during build - Modifies
rootless-install.shto use dynamically populated version variables instead of hardcoded values - Updates CI workflows to provide GitHub authentication token for API calls
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/get-version.sh | New script that queries GitHub API to fetch latest Docker versions for stable and test channels |
| Makefile | Adds version retrieval logic, error checking for empty versions, and passes version variables to envsubst |
| rootless-install.sh | Replaces hardcoded version strings with environment variables populated at build time |
| .github/workflows/diff.yml | Adds GH_TOKEN environment variable for GitHub CLI authentication |
| .github/workflows/ci.yml | Adds GH_TOKEN environment variable for GitHub CLI authentication and updates rootless install test to use built artifact |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When building the final install.sh script - fill the latest versions based on Github releases. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
rootless-auto-versions
branch
from
e60e2b2 to
955c0d7
Compare
2 participants
When building the final install.sh script - fill the latest versions based on Github releases.
With this we no longer need to manually the rootless versions via PRs like this: #531