Improve docopt-config.cmake in case of Boost regex #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit declares the transitive dependency to Boost in case docopt is build with Boost regex support. In this way, the user doesn't need to declare the dependency to Boost manually.
|
I'm not a make expert so it'd be nice to get some other eyes on this that can confirm this approach is reasonable. |
eaaltonen
approved these changes
May 30, 2022
There was a problem hiding this comment.
LGTM. I tested this on a local project with docopt built with option -DUSE_BOOST_REGEX=True. Dependency works as expected and the CMake follows CMake packaging instructions AFAICT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit declares the transitive dependency to Boost in case docopt is build with Boost regex support. In this way, the user doesn't need to declare the dependency to Boost manually.