Merge release 3.9.3 into 3.10.x #1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
This fix prevents the DiffGenerator from stripping schemas from table names before applying the asset filter (usually a regex pattern). It aligns its behavior with the ORM's schema generator and fixes a bug on platforms without schema support, where a table name containing a dot would be incorrectly stripped of the part before the first dot. The resolveTableName() method has been removed entirely because it is no longer needed and was causing inconsistent behavior. On platforms that support schemas (e.g., PostgreSQL, SQL Server), DBAL provides qualified table names (schema.table) which should be preserved for proper filtering. On platforms that don't support schemas (e.g., MySQL, SQLite), DBAL already provides unqualified table names, making the schema stripping unnecessary. The original purpose of resolveTableName() was to handle cases where table names might contain dots on platforms without schema support, but this approach was flawed because it incorrectly assumed any dot represented a schema separator. This could break legitimate table names containing dots on platforms like SQLite. By removing this method and letting DBAL handle the platform-specific table name formatting, we achieve consistent behavior across all platforms while fixing the schema filtering issue. Testing confirms that removing this method works correctly: on schema-aware platforms, qualified names are properly filtered, and on non-schema platforms, table names are already unqualified by DBAL. Fixes #1487
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ons/download-artifact-5 Bump actions/download-artifact from 4 to 5
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
DiffGenerator: fix removing schema from table name before applying regex filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 3.9.3
3.9.x bugfix release (patch)
3.9.3
CI
Bug