test: optimize database connection test logic #2991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a 1-second wait time before each test to ensure the database has started Update error assertions to match more specific error messages Adjust the test order: first test the case where the user does not exist, then test the case where the password is incorrect
Adjust code import order - Adjust the import order of "github.com/gocraft/dbr/v2" to before "github.com/stretchr/testify/assert" - This change does not add or remove any functionality, it just reorganizes the order of import statements
zachmu
reviewed
May 28, 2025
| conn, err := dbr.Open("mysql", fmt.Sprintf("no_user:@tcp(%s:%d)/%s", address, port, dbName), nil) | ||
| require.NoError(t, err) | ||
| require.ErrorContains(t, conn.Ping(), "User not found") |
There was a problem hiding this comment.
Pretty sure we want to keep these around
There was a problem hiding this comment.
I reverted it，pls check again
There was a problem hiding this comment.
I've been out of the office on leave, but this looks good.
zachmu
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a 1-second wait time before each test to ensure the database has started
Update error assertions to match more specific error messages
Adjust the test order: first test the case where the user does not exist, then test the case where the password is incorrect