Add support for VECTOR type #3162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktobey
force-pushed
the
nicktobey/vector2
branch
from
33bc757 to
0bae5a0
Compare
nicktobey
force-pushed
the
nicktobey/vector2
branch
2 times, most recently
from
90102d4 to
d955334
Compare
macneale4
requested changes
Aug 19, 2025
…simplifies the logic a lot.
macneale4
approved these changes
Aug 20, 2025
| @@ -325,10 +329,22 @@ func ConvertToBool(ctx *Context, v interface{}) (bool, error) { | |||
| } | |||
| } | |||
|
|
|||
| // DecodeVector decodes a byte slice that represents a vector. This is needed for distance functions. | |||
| func DecodeVector(buf []byte) []float32 { | |||
| return unsafe.Slice((*float32)(unsafe.Pointer(&buf[0])), len(buf)/int(values.Float32Size)) | |||
There was a problem hiding this comment.
seems like a check to ensure that len(buf) % int(values.Float32Size) == 0 would be prudent.
Is there some additional safety we have on the input which I'm not seeing here?
| return nil, sql.OutOfRange, fmt.Errorf("VECTOR dimension mismatch: expected %d, got %d", t.Dimensions, len(val)) | ||
| if t.Dimensions != 0 && len(val) != int(values.Float32Size)*t.Dimensions { | ||
| if len(val)%int(values.Float32Size) != 0 { | ||
| return nil, sql.OutOfRange, fmt.Errorf("cannot convert BINARY(%d) to VECTOR(%d), need BINARY(%d)", len(val), t.Dimensions, 4*t.Dimensions) |
There was a problem hiding this comment.
Suggested change
| return nil, sql.OutOfRange, fmt.Errorf("cannot convert BINARY(%d) to VECTOR(%d), need BINARY(%d)", len(val), t.Dimensions, 4*t.Dimensions) | |
| return nil, sql.OutOfRange, fmt.Errorf("cannot convert BINARY(%d) to VECTOR(%d), need BINARY(%d)", len(val), t.Dimensions, int(values.Float32Size)*t.Dimensions) |
| if len(val)%int(values.Float32Size) != 0 { | ||
| return nil, sql.OutOfRange, fmt.Errorf("cannot convert BINARY(%d) to VECTOR(%d), need BINARY(%d)", len(val), t.Dimensions, 4*t.Dimensions) | ||
| } | ||
| return nil, sql.OutOfRange, fmt.Errorf("VECTOR dimension mismatch: expected %d, got %d", t.Dimensions, len(val)/4) |
There was a problem hiding this comment.
Suggested change
| return nil, sql.OutOfRange, fmt.Errorf("VECTOR dimension mismatch: expected %d, got %d", t.Dimensions, len(val)/4) | |
| return nil, sql.OutOfRange, fmt.Errorf("VECTOR dimension mismatch: expected %d, got %d", t.Dimensions, len(val)/int(values.Float32Size)) |
nicktobey
force-pushed
the
nicktobey/vector2
branch
from
2953ab3 to
817084a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a VECTOR type to GMS. Vectors are arrays of 32-bit floats.
It also adds several functions that take vectors as arguments, including converting vectors to and from strings, and functions for computing distances between vectors.
Finally, it ensures that vector types work correctly when passed to existing functions (such as BIT_LENGTH, MD5, etc.)