Skip to content

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Sep 19, 2025

Fixes #36126

cc: @hakenr

Let's see about filling in the additional detail following the work in #36094:

  • Move the trimming granularity section up to facilitate the Configuration section cross-linking to it with more information.
  • Explain the use of <IsTrimmable> in the Configuration section.
  • Cross-link the "explicitly opted in" remark of the Custom type section to the Configuration section, and add "class libraries" to it to clarify what is being opted-in.

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/host-and-deploy/configure-trimmer.md aspnetcore/blazor/host-and-deploy/configure-trimmer

@guardrex guardrex self-assigned this Sep 19, 2025
@guardrex guardrex requested a review from Copilot September 19, 2025 08:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the trimming guidance for ASP.NET Core Blazor applications by reorganizing content and adding more specific information about class library opt-in behavior. The changes improve the documentation's structure and provide clearer guidance on configuring trimming for class libraries.

Key changes:

  • Reorganizes content by moving the trimming granularity section earlier in the document
  • Adds detailed explanation of the <IsTrimmable> property for class library trimming opt-in
  • Improves cross-references between sections to better connect related concepts

@guardrex guardrex requested a review from danroth27 September 19, 2025 08:45
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions to discuss.

@guardrex
Copy link
Collaborator Author

@danroth27 ... I made your suggested changes with only minor style tweaks.

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment.

@guardrex guardrex merged commit 85c2676 into main Sep 22, 2025
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-trimming-update branch September 22, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover the IsTrimmable property
2 participants