-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Further opt-in trimming guidance (class libs) #36127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the trimming guidance for ASP.NET Core Blazor applications by reorganizing content and adding more specific information about class library opt-in behavior. The changes improve the documentation's structure and provide clearer guidance on configuring trimming for class libraries.
Key changes:
- Reorganizes content by moving the trimming granularity section earlier in the document
- Adds detailed explanation of the
<IsTrimmable>
property for class library trimming opt-in - Improves cross-references between sections to better connect related concepts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions to discuss.
@danroth27 ... I made your suggested changes with only minor style tweaks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor comment.
Co-authored-by: Daniel Roth <[email protected]>
Fixes #36126
cc: @hakenr
Let's see about filling in the additional detail following the work in #36094:
<IsTrimmable>
in the Configuration section.Internal previews