-
Notifications
You must be signed in to change notification settings - Fork 708
Update the templates for .NET 10 #12267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DamianEdwards
wants to merge
14
commits into
main
Choose a base branch
from
damianedwards/dev-localhost-net10-templates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fa49d5b
Update templates for .NET 10
DamianEdwards 6bafc58
Ensure *.localhost resource URLs are given priority in dashboard
DamianEdwards 2eac314
More template config tweaks
DamianEdwards 6f02fe7
Fix localhosttld option in VS
DamianEdwards 0de2f51
More fixes & enable *.localhost for python starter
DamianEdwards 1f06d5f
Fix launch profile URL in aspire empty template
DamianEdwards ba1a7a1
Simplify template aspire version config
DamianEdwards a1133fe
Update to OTel 1.13.x
DamianEdwards 878ae49
Merge branch 'main' into damianedwards/dev-localhost-net10-templates
DamianEdwards 1ceee36
Use EndpointHostHelpers
DamianEdwards fcf9104
Apply *.dev.localhost URLs to all resources if AppHost is using it
DamianEdwards 987fe56
Fix
DamianEdwards 089512e
Only apply apphost dev.localhost host name to HTTP endpoint URLs
DamianEdwards f2fabba
Make .dev.localhost opt-in in templates
DamianEdwards File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are surprising in this PR. Are these intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is to optimize what's shown in the dashboard for resources using *.localhost URLs, which includes the Blazor app in the Aspire starter template. Without this change, you get four URLs shown on the resources summary page, and the https://localhost:1234 URL is the first one shown, which is not optimal. This changes it so that the summary page only shows the *.localhost URLs if they're used, and moves the localhost URLs to the details pane.