Skip to content

Add proper handling when a property’s backing field cannot be inferred or the unsafe accessor cannot be generated. #36720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add proper handling when a property’s backing field cannot be inferred or the unsafe accessor cannot be generated. #36720

wants to merge 2 commits into from

Conversation

kawasaniac
Copy link

@kawasaniac kawasaniac commented Sep 7, 2025 •
edited
Loading

My take on adding additional handling for the following issue: #35219

Throws InvalidOperationException with proper message as in DesignStrings (CompiledModelBackingFieldNotFound and CompiledModelUnsafeAccessorNull). Plus added additional exceptions specifically for this case.

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@kawasaniac
Proper exception handling for RegisterPrivateAccessor()
bbb32c0 
- Add proper handling when a property’s backing field cannot be inferred or the unsafe accessor cannot be generated.
- Add DesignStrings methods and entries to .resx

Fixes dotnet#35219
@kawasaniac kawasaniac requested a review from a team as a code owner September 7, 2025 18:45
@kawasaniac
Copy link
Author

@dotnet-policy-service agree

@AndriySvyryd AndriySvyryd self-assigned this Sep 8, 2025
AndriySvyryd
AndriySvyryd reviewed Sep 11, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd requested changes Sep 11, 2025
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for these cases to https://github.com/dotnet/efcore/blob/release/10.0/test/EFCore.Specification.Tests/Scaffolding/CompiledModelTestBase.cs

@AndriySvyryd AndriySvyryd changed the base branch from release/10.0 to main September 19, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@AndriySvyryd AndriySvyryd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kawasaniac @AndriySvyryd