Fix handling of readonly fields using abstract classes (i.e. FrozenSet<T>) in parameters for primitive collections. #36757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T>) in parameters for primitive collections.
cincuranet
changed the title
roji
approved these changes
Sep 16, 2025
Comment on lines
+92
to
+94
| // For collections that are abstract (i.e. FrozenSet<T>) the compiler uses some "internal" | ||
| // implementation and for readonly fields the compiler adds explicit cast. We need to | ||
| // unwrap here. |
There was a problem hiding this comment.
Suggested change
| // For collections that are abstract (i.e. FrozenSet<T>) the compiler uses some "internal" | |
| // implementation and for readonly fields the compiler adds explicit cast. We need to | |
| // unwrap here. | |
| // For collections that are abstract (i.e. FrozenSet<T>), some internal type is used | |
| // and for readonly fields the compiler adds explicit cast. We need to unwrap here. |
| if (expression is UnaryExpression { NodeType: ExpressionType.Convert } convertExpression | ||
| && convertExpression.Type.GetGenericTypeDefinition() == typeof(IEnumerable<>)) | ||
| && convertExpression.Type.GetGenericTypeImplementations(typeof(IEnumerable<>)) is not null) |
There was a problem hiding this comment.
Given that below we match on non-generic IEnumerable, should we match for this here as well instead of the generic variant?
| using System.Collections.Immutable; | ||
|
|
||
| namespace Microsoft.EntityFrameworkCore.Query; | ||
|
|
||
| public abstract class PrimitiveCollectionsQueryTestBase<TFixture>(TFixture fixture) : QueryTestBase<TFixture>(fixture) | ||
| where TFixture : PrimitiveCollectionsQueryTestBase<TFixture>.PrimitiveCollectionsQueryFixtureBase, new() | ||
| { | ||
| // List<T> is a regular class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36496