Skip to content

Conversation

@JoasE
Copy link
Contributor

@JoasE JoasE commented Oct 27, 2025

Implements: #36599

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@JoasE JoasE marked this pull request as ready for review October 27, 2025 20:17
@JoasE JoasE requested a review from a team as a code owner October 27, 2025 20:17
@JoasE
Copy link
Contributor Author

JoasE commented Oct 28, 2025

Pipeline appears to have an error running EFCore.InMemory.FunctionalTests but they succeed locally.

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add some functional tests, including ones that combine bulk execution with batching or eTags?

@JoasE
Copy link
Contributor Author

JoasE commented Nov 1, 2025

@AndriySvyryd I don't think any behavior from cosmos or the sdk changes when you enable bulk execution. I can add a tests that verify that? Basically inheriting from the tests that already exist and running those with bulk enabled

@JoasE
Copy link
Contributor Author

JoasE commented Nov 1, 2025

I'm actually now realizing that this doesn't make a lot of sense. When using bulk, you probably want to execute the entries to save in parallel. Otherwise the only bulk that can happen is between different contexts. Will close this if you agree and see if I have time to implement that after #37027 is merged. (as it will probably have conflicts) I will have to think on how to best handle the parallelism (with manual session token management) and if we should only do in parallel with bulk or maybe increase parallelism without as well. (but probably only with bulk)

@JoasE JoasE marked this pull request as draft November 1, 2025 16:47
@JoasE JoasE mentioned this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants