CI(macOS x64): install libomp from Homebrew Core (drop local libomp.rb) #7501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix macOS x64 CI: install
libomp
via Homebrew tap (no local formula)Branch:
fix-macos-libomp
Scope: CI only – changes limited to
build/ci/job-template.yml
(macOS x64 job)What & Why
On macOS x64 jobs, our pipeline tries to install OpenMP via a local Homebrew formula:
brew install $(Build.SourcesDirectory)/build/libomp.rb --build-from-source --formula
Recent Homebrew (4.6+) rejects local, untapped formulae and fails with:
This does not affect
macOS_cross_arm64
jobs because they already use the officialhomebrew/core
formula (brew install libomp
).The fix
For macOS x64 only, switch to the official tap-hosted formula and force a link so the headers and libs are discoverable by our native builds:
No product/code changes; CI infra-only.
Validation
macOS_x64
with the error above.macOS_cross_arm64
continues to use the official tap and succeeds.libomp
and exposes headers (/usr/local/opt/libomp/include
) and libs (/usr/local/opt/libomp/lib
).Risk & Impact
Alternative considered
libomp.rb
. Rejected to avoid long‑term maintenance overhead when the official formula suffices.Change summary
build/ci/job-template.yml
macOS x64 path:brew update && brew install libomp && brew link libomp --force
.How to verify in CI
macOS_x64 Debug_Build
.OneDalNative
on macOS unless explicitly provided (unrelated to this PR).Notes for maintainers
src/
or packaging. It is safe to service‑merge.libomp
).Checklist (author)
Screenshots / logs (for context)
Failure (before):
Success (after):