Better handle attribute snippet completion in components #12281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2) Break apart snippet context detection 3) Make local functions static
2) Add a couple statics for common IA collections
… to when creating a commit character for "=" 2) Have the AddCompletion method return a RazorCommitCharacter instead of a string, to indicate whether the commit should insert the commit character 3) Add a couple more statics that are commonly used. 4) Add test
ToddGrun
changed the title
|
@dotnet/razor-tooling ptal |
chsienki
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
LGTM, but may want to wait for @davidwengier to take a look too
davidwengier
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
It would be really good if you could do a quick test of this and #12271 in VS Code to make sure nothing regresses there. Feels like this area of completion keeps changing, and I wonder if we're accidentally yo-yo-ing between working in VS, and VS Code, and fixing for one breaks the other. Or we just have lots of little bugs. I'd believe either one tbh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handle attribute snippet completion in components
This addresses a scenario where completion commit would insert an extra '=' inside the attribute value. For example, committing "@ref" via typing '=' in this code
below would end up with the following document contents:
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2581843