Skip to content

More MS.CA.CSharp resource cleanup #80100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

More MS.CA.CSharp resource cleanup #80100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 0 additions & 66 deletions src/Compilers/CSharp/Portable/CSharpResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3376,9 +3376,6 @@ A catch() block after a catch (System.Exception e) block can catch non-CLS excep
<data name="ERR_CollectionInitRequiresIEnumerable" xml:space="preserve">
<value>Cannot initialize type '{0}' with a collection initializer because it does not implement 'System.Collections.IEnumerable'</value>
</data>
<data name="ERR_CantSetWin32Manifest" xml:space="preserve">
<value>Error reading Win32 manifest file '{0}' -- '{1}'</value>
</data>
<data name="WRN_CantHaveManifestForModule" xml:space="preserve">
<value>Ignoring /win32manifest for module because it only applies to assemblies</value>
</data>
Expand Down Expand Up @@ -3920,9 +3917,6 @@ You should consider suppressing the warning only if you're sure that you don't w
<data name="ERR_NamedArgumentForArray" xml:space="preserve">
<value>An array access may not have a named argument specifier</value>
</data>
<data name="ERR_NotYetImplementedInRoslyn" xml:space="preserve">
Copy link
Contributor

@AlekseyTs AlekseyTs Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERR_NotYetImplementedInRoslyn

This one should probably be preserved. #Closed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not present in the enum, why to keep the unused resource around?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not present in the enum, why to keep the unused resource around?

If it is not present in the enum, then removing is fine

<value>This language feature ('{0}') is not yet implemented.</value>
</data>
<data name="ERR_DefaultValueNotAllowed" xml:space="preserve">
<value>Default values are not valid in this context.</value>
</data>
Expand Down Expand Up @@ -4265,24 +4259,6 @@ You should consider suppressing the warning only if you're sure that you don't w
<data name="ERR_MixingWinRTEventWithRegular" xml:space="preserve">
<value>'{0}' cannot implement '{1}' because '{2}' is a Windows Runtime event and '{3}' is a regular .NET event.</value>
</data>
<data name="WRN_CA2000_DisposeObjectsBeforeLosingScope1" xml:space="preserve">
<value>Call System.IDisposable.Dispose() on allocated instance of {0} before all references to it are out of scope.</value>
</data>
<data name="WRN_CA2000_DisposeObjectsBeforeLosingScope1_Title" xml:space="preserve">
<value>Call System.IDisposable.Dispose() on allocated instance before all references to it are out of scope</value>
</data>
<data name="WRN_CA2000_DisposeObjectsBeforeLosingScope2" xml:space="preserve">
<value>Allocated instance of {0} is not disposed along all exception paths. Call System.IDisposable.Dispose() before all references to it are out of scope.</value>
</data>
<data name="WRN_CA2000_DisposeObjectsBeforeLosingScope2_Title" xml:space="preserve">
<value>Allocated instance is not disposed along all exception paths</value>
</data>
<data name="WRN_CA2202_DoNotDisposeObjectsMultipleTimes" xml:space="preserve">
<value>Object '{0}' can be disposed more than once.</value>
</data>
<data name="WRN_CA2202_DoNotDisposeObjectsMultipleTimes_Title" xml:space="preserve">
<value>Object can be disposed more than once</value>
</data>
<data name="ERR_NewCoClassOnLink" xml:space="preserve">
<value>Interop type '{0}' cannot be embedded. Use the applicable interface instead.</value>
</data>
Expand Down Expand Up @@ -4879,9 +4855,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="ERR_AutoPropertyMustOverrideSet" xml:space="preserve">
<value>Auto-implemented properties must override all accessors of the overridden property.</value>
</data>
<data name="ERR_InitializerInStructWithoutExplicitConstructor" xml:space="preserve">
<value>Structs without explicit constructors cannot contain members with initializers.</value>
</data>
<data name="ERR_EncodinglessSyntaxTree" xml:space="preserve">
<value>Cannot emit debug information for a source text without encoding.</value>
</data>
Expand All @@ -4891,9 +4864,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="ERR_SwitchFallOut" xml:space="preserve">
<value>Control cannot fall out of switch from final case label ('{0}')</value>
</data>
<data name="ERR_UnexpectedBoundGenericName" xml:space="preserve">
<value>Type arguments are not allowed in the nameof operator.</value>
</data>
<data name="ERR_NullPropagatingOpInExpressionTree" xml:space="preserve">
<value>An expression tree lambda may not contain a null propagating operator.</value>
</data>
Expand Down Expand Up @@ -5084,15 +5054,9 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="WRN_RefReturnNonreturnableLocal2_Title" xml:space="preserve">
<value>A member is returned by reference but was initialized to a value that cannot be returned by reference</value>
</data>
<data name="ERR_RefReturnReadonlyLocal" xml:space="preserve">
<value>Cannot return '{0}' by reference because it is read-only</value>
</data>
<data name="ERR_RefReturnRangeVariable" xml:space="preserve">
<value>Cannot return the range variable '{0}' by reference</value>
</data>
<data name="ERR_RefReturnReadonlyLocalCause" xml:space="preserve">
<value>Cannot return '{0}' by reference because it is a '{1}'</value>
</data>
<data name="ERR_RefReturnReadonly" xml:space="preserve">
<value>A readonly field cannot be returned by writable reference</value>
</data>
Expand Down Expand Up @@ -5204,27 +5168,9 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="ERR_EscapeCall2" xml:space="preserve">
<value>Cannot use a member of result of '{0}' in this context because it may expose variables referenced by parameter '{1}' outside of their declaration scope</value>
</data>
<data name="WRN_EscapeCall" xml:space="preserve">
<value>Use of result of '{0}' in this context may expose variables referenced by parameter '{1}' outside of their declaration scope</value>
</data>
<data name="WRN_EscapeCall_Title" xml:space="preserve">
<value>Use of result in this context may expose variables referenced by parameter outside of their declaration scope</value>
</data>
<data name="WRN_EscapeCall2" xml:space="preserve">
<value>Use of member of result of '{0}' in this context may expose variables referenced by parameter '{1}' outside of their declaration scope</value>
</data>
<data name="WRN_EscapeCall2_Title" xml:space="preserve">
<value>Use of member of result in this context may expose variables referenced by parameter outside of their declaration scope</value>
</data>
<data name="ERR_CallArgMixing" xml:space="preserve">
<value>This combination of arguments to '{0}' is disallowed because it may expose variables referenced by parameter '{1}' outside of their declaration scope</value>
</data>
<data name="WRN_CallArgMixing" xml:space="preserve">
<value>This combination of arguments to '{0}' may expose variables referenced by parameter '{1}' outside of their declaration scope</value>
</data>
<data name="WRN_CallArgMixing_Title" xml:space="preserve">
<value>This combination of arguments may expose variables referenced by parameter outside of their declaration scope</value>
</data>
<data name="ERR_MismatchedRefEscapeInTernary" xml:space="preserve">
<value>Branches of a ref conditional operator cannot refer to variables with incompatible declaration scopes</value>
</data>
Expand Down Expand Up @@ -6035,9 +5981,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="ERR_LambdaExplicitReturnTypeVar" xml:space="preserve">
<value>The contextual keyword 'var' cannot be used as an explicit lambda return type</value>
</data>
<data name="ERR_SingleElementPositionalPatternRequiresDisambiguation" xml:space="preserve">
<value>A single-element deconstruct pattern requires some other syntax for disambiguation. It is recommended to add a discard designator '_' after the close paren ')'.</value>
</data>
<data name="ERR_VarMayNotBindToType" xml:space="preserve">
<value>The syntax 'var' for a pattern is not permitted to refer to a type, but '{0}' is in scope here.</value>
</data>
Expand Down Expand Up @@ -6209,9 +6152,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="WRN_GivenExpressionAlwaysMatchesPattern_Title" xml:space="preserve">
<value>The given expression always matches the provided pattern.</value>
</data>
<data name="ERR_FeatureNotAvailableInVersion8_0" xml:space="preserve">
<value>Feature '{0}' is not available in C# 8.0. Please use language version {1} or greater.</value>
</data>
<data name="ERR_PointerTypeInPatternMatching" xml:space="preserve">
<value>Pattern-matching is not permitted for pointer types.</value>
</data>
Expand Down Expand Up @@ -7098,9 +7038,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="WRN_UseDefViolationPropertyUnsupportedVersion_Title" xml:space="preserve">
<value>Use of possibly unassigned auto-implemented property. Consider updating the language version to auto-default the property.</value>
</data>
<data name="ERR_UnsupportedTypeForSlicePattern" xml:space="preserve">
<value>Slice patterns may not be used for a value of type '{0}'.</value>
</data>
<data name="ERR_MisplacedSlicePattern" xml:space="preserve">
<value>Slice patterns may only be used once and directly inside a list pattern.</value>
</data>
Expand Down Expand Up @@ -7384,9 +7321,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="IDS_FeatureUtf8StringLiterals" xml:space="preserve">
<value>UTF-8 string literals</value>
</data>
<data name="ERR_ExpressionTreeContainsUtf8StringLiterals" xml:space="preserve">
Copy link
Contributor

@AlekseyTs AlekseyTs Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERR_ExpressionTreeContainsUtf8StringLiterals

Is this really not used? #Closed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any mentions of it in the enum (not even commented out line)

<value>An expression tree may not contain UTF-8 string conversion or literal.</value>
</data>
<data name="ERR_ChainingToSetsRequiredMembersRequiresSetsRequiredMembers" xml:space="preserve">
<value>This constructor must add 'SetsRequiredMembers' because it chains to a constructor that has that attribute.</value>
</data>
Expand Down
Loading