Report analyzer load failures as MSBuild workspace diagnostics. #80109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force the loading of analyzers and generators when loading projects for the MSBuild Workspace. This gives us the opportunity to report failures as workspace diagnostics. Related to #77980
Comment on lines
+426
to
+427
| // Force loading of the analyzers so that we can record any load failures now. | ||
| foreach (var analyzerReference in analyzerReferences.OfType<AnalyzerFileReference>()) |
There was a problem hiding this comment.
This seems a bit expensive if you're not going to be actually looking at all the projects (or only looking at source). Isn't there a MEF factory this could export that can hook this up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force the loading of analyzers and generators when loading projects for the MSBuild Workspace. This gives us the opportunity to report failures as workspace diagnostics.
Related to #77980