Avoid localizing parameter name #80116
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
CyrusNajmabadi
approved these changes
Sep 3, 2025
|
|
||
| For Each tree As SyntaxTree In trees | ||
| If tree Is Nothing Then | ||
| Throw New ArgumentNullException(String.Format(VBResources.Trees0, i)) |
There was a problem hiding this comment.
can this resource be removed? or is still needed for seomthing else? does teh C# side do teh same thing?
There was a problem hiding this comment.
@CyrusNajmabadi Yes it should be removed. I have the removal already in #80098 so I didn't redo it here, but if you prefer to do in this PR I'm fine with it.
There was a problem hiding this comment.
C# side doesn't localize:
roslyn/src/Compilers/CSharp/Portable/Compilation/CSharpCompilation.cs
Lines 903 to 906 in 09be0d7
There was a problem hiding this comment.
thanks. i'm fine either way. if it's coming in anotehr pr, that works for me.
jjonescz
approved these changes
Sep 4, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter name that's part of
ArgumentNullExceptionshould not be localized.