-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Expand test coverage for native AOT on android #121217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbomer
wants to merge
46
commits into
main
Choose a base branch
from
sbomer/naot-android-coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
3bf76d6
Add more native AOT on android ci test coverage
sbomer 432572c
Remove --cross argument, fix and disable some libs tests
sbomer 214d1f9
Remove --cross argument, fix and disable some libs tests
sbomer a9eeff0
Set runtimeFlavor to coreclr
sbomer 5253ab2
Parameterize runtimeFlavor in Android job definitions
sbomer 9d8577b
Remove runtimeFlavor: coreclr from Android emulator pipeline
sbomer fef0415
Fix typo in runtimeFlavor parameter name
sbomer c509f51
Add 'nativeaot' arg to testBuildArgs for Android emulator
sbomer 4cbbff5
Increase timeout to 180
sbomer c1292f1
Refactor Android NDK compiler selection for test builds
sbomer dfbf8ea
Increase timeout to 240
sbomer b8abeba
Pass RuntimeFlavor to AndroidAppBuilderTask
sbomer cc1d5c3
Check TestBuildMode instead
sbomer 2b7f252
Fix a few test failures
sbomer 1ee5f13
Set Environment.CurrentDirectory to app files directory
sbomer cce4d9a
Exclude tests failing due to missing calli marshalling support
sbomer e6338fb
Exclude tests failing due to missing crypto shim export
sbomer 5c723f5
Enable building smoke tests as apks
sbomer d0d7bc3
Fix smoke test build for android
sbomer eec6deb
Disable directory apk build for smoke tests
sbomer 4ed06ec
Try using merged test runners
sbomer cbcca7d
Revert "Try using merged test runners"
sbomer 37b7b4e
Add Merged marker for smoke tests
sbomer 9e89dda
Try merged wrappers again
sbomer 3a266b8
Revert "Add Merged marker for smoke tests"
sbomer a0c0cd6
Fix some issues with non-standalone build
sbomer 55b18f5
Remove buildAllTestsAsStandalone
sbomer 8e60575
Set expected exit code
sbomer 9f6e630
Remove redundant import
sbomer d4d4ad3
Fix mono test build
sbomer 92eb56d
Set exit code as metadata for helix
sbomer 7d7322b
Write ExpectedExitCode.txt
sbomer 66edced
Remove condition on monodroid-nativeaot.cs
sbomer d5e5497
Disable some failing tests
sbomer dce1301
Use __managed__Main, move suppession to common targets
sbomer 64ec45a
Merge remote-tracking branch 'origin/main' into naot-android-coverage
sbomer 18b1964
Clean up disabled tests
sbomer d0edc55
Revert SmokeTest entry point code changes
sbomer 52b22d5
Skip/enable some more tests
sbomer aabde97
Fix non-android build, disable test
sbomer d08f20b
Re-enable passing tests
sbomer 6ea7cb9
PR feedback
sbomer 910abed
PR feedback and cleanup
sbomer 776f3e1
Add comment about runtime tests
sbomer 61e4a37
Try to fix condition for SingleFileTestRunner, fix test failure
sbomer 216417e
Move shared props out of nativeaot dir
sbomer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <Project> | ||
| <PropertyGroup Condition="'$(TargetOS)' == 'android'"> | ||
| <NdkToolchainPrebuiltOS Condition="$([MSBuild]::IsOSPlatform('Linux'))">linux-x86_64</NdkToolchainPrebuiltOS> | ||
| <NdkToolchainPrebuiltOS Condition="$([MSBuild]::IsOSPlatform('OSX'))">darwin-x86_64</NdkToolchainPrebuiltOS> | ||
| <NdkToolchainPrebuiltOS Condition="$([MSBuild]::IsOSPlatform('Windows'))">windows-x86_64</NdkToolchainPrebuiltOS> | ||
| <CppCompilerAndLinker Condition="'$(CppCompilerAndLinker)' == ''">$(ANDROID_NDK_ROOT)\toolchains\llvm\prebuilt\$(NdkToolchainPrebuiltOS)\bin\clang</CppCompilerAndLinker> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.